gh-148285: Allow recording uops after specializing uops#148367
Open
adityakrmishra wants to merge 2 commits intopython:mainfrom
Open
gh-148285: Allow recording uops after specializing uops#148367adityakrmishra wants to merge 2 commits intopython:mainfrom
adityakrmishra wants to merge 2 commits intopython:mainfrom
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue:
Currently,
analyzer.pyuses a strict positionalfirst = Truecheck when validatingmacrostructures. This strictly forces any uop withrecords_value == Trueto be at index 0, which prevents Tier 2 recording uops from safely trailing Tier 1 specializing uops.The Fix:
Replaced the boolean
firstcheck with a state tracker (valid_recording_pos) inadd_macro().valid_recording_posstarts asTrue.Trueif the parsed part is a specializing uop (uop.properties.tier == 1).CacheEffectandflushparts.Falsefor any other instruction, properly closing the gate.This safely allows structures like:
macro(X) = _SPECIALIZE_X + _RECORD_TOS_TYPE + unused/1 + _X;