gh-148211: decompose [_POP_TWO/_INSERT_2]_LOAD_CONST_INLINE_BORROW in JIT#148357
gh-148211: decompose [_POP_TWO/_INSERT_2]_LOAD_CONST_INLINE_BORROW in JIT#148357NekoAsakura wants to merge 2 commits intopython:mainfrom
[_POP_TWO/_INSERT_2]_LOAD_CONST_INLINE_BORROW in JIT#148357Conversation
|
Conflicts already 😲 JIT is moving so fast. |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Awesome, another nice simplification. Thanks!
Yeah there're like 5 active contributors sending stuff to the JIT almost daily. It's a happy problem :). |
|
@NekoAsakura I would like to add you to the contributors in the What's New page. Would you be alright with that and do you mind if I use your |
That'd be lovely, thanks! Would it be alright to use a different name though? |
Yeah of course. |
|
I'll open the PR to add new JIT contributors. Give me a moment. Will tag you in it. |
| ("_SWAP", "3, 0"), | ||
| ("_SWAP", "2, 0")], |
There was a problem hiding this comment.
This seems a little inefficient, but I think it should be fine as it's just a register to register move with stack caching in the JIT.
There was a problem hiding this comment.
Are there any better practices for this?
There was a problem hiding this comment.
don't think so: no matter what you do, you probably have to shuffle the register anyways. We can remove some movs, but I doubt that will speed up things by that much on modern CPUs considering register renaming is a thing.
There was a problem hiding this comment.
Sound about right.
Uh oh!
There was an error while loading. Please reload this page.