gh-148325: Add PyObject_GetItemData() to the limited C API and stable ABI#148324
Open
wjakob wants to merge 1 commit intopython:mainfrom
Open
gh-148325: Add PyObject_GetItemData() to the limited C API and stable ABI#148324wjakob wants to merge 1 commit intopython:mainfrom
PyObject_GetItemData() to the limited C API and stable ABI#148324wjakob wants to merge 1 commit intopython:mainfrom
Conversation
…able ABI Move PyObject_GetItemData and PyObject_GetItemData_DuringGC from the unstable CPython API (Include/cpython/object.h) to the limited C API (Include/object.h), gated on Py_LIMITED_API >= 3.15, and declare them as part of the stable ABI in Misc/stable_abi.toml.
PyObject_GetItemData() to the limited C API and stable ABI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR promotes
PyObject_GetItemData()andPyObject_GetItemData_DuringGC()to the stable ABI (analogous toPyObject_GetTypeData()andPyObject_GetTypeData_DuringGC()that are already in the stable ABI).The function
PyObject_GetItemData()is needed to access the entries of variable sized objects (PyVarObject).Why this change?
PyVarObjectbecomes opaque inabi3t.PyObject_GetItemData(), nanobind cannot run onabi3t.I am urgently (⚠️ ) trying to still get this into Python 3.15.
@vstinner @ngoldbaum @encukou
📚 Documentation preview 📚: https://cpython-previews--148324.org.readthedocs.build/