gh-148254: Use singular "sec" in timeit verbose output#148290
Merged
hugovk merged 1 commit intopython:mainfrom Apr 9, 2026
Merged
gh-148254: Use singular "sec" in timeit verbose output#148290hugovk merged 1 commit intopython:mainfrom
hugovk merged 1 commit intopython:mainfrom
Conversation
Change "secs" to "sec" in the verbose callback of timeit.main() for consistency with other time units (nsec, usec, msec, sec) used elsewhere in the module output.
|
All commit authors signed the Contributor License Agreement. |
hugovk
approved these changes
Apr 9, 2026
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
This is a bugfix, let's backport?
Member
+1 |
|
Sorry, @gaweng and @hugovk, I could not cleanly backport this to |
|
Sorry, @gaweng and @hugovk, I could not cleanly backport this to |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Apr 9, 2026
…ythonGH-148290) (cherry picked from commit d8c5658) Co-authored-by: gaweng <38250674+gaweng@users.noreply.github.com>
|
GH-148303 is a backport of this pull request to the 3.14 branch. |
|
GH-148304 is a backport of this pull request to the 3.13 branch. |
Member
|
@gaweng Thank you and congratulations on your first contribution! |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Apr 9, 2026
…ythonGH-148290) (cherry picked from commit d8c5658) Co-authored-by: gaweng <38250674+gaweng@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Apr 9, 2026
hugovk
added a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change "secs" to "sec" in the verbose callback of timeit.main() for consistency with other time units (nsec, usec, msec, sec) used elsewhere in the module output.
timeithardcodes plural "secs" #148254