gh-143732: Add tier2 specialization for TO_BOOL#148271
Open
eendebakpt wants to merge 4 commits intopython:mainfrom
Open
gh-143732: Add tier2 specialization for TO_BOOL#148271eendebakpt wants to merge 4 commits intopython:mainfrom
eendebakpt wants to merge 4 commits intopython:mainfrom
Conversation
Sacul0457
reviewed
Apr 8, 2026
Comment on lines
+541
to
+550
| if (sym_matches_type(value, &PyDict_Type)) { | ||
| REPLACE_OP(this_instr, _TO_BOOL_DICT, 0, 0); | ||
| } | ||
| else if (sym_matches_type(value, &PyTuple_Type) || | ||
| sym_matches_type(value, &PySet_Type) || | ||
| sym_matches_type(value, &PyFrozenSet_Type) || | ||
| sym_matches_type(value, &PyBytes_Type) || | ||
| sym_matches_type(value, &PyByteArray_Type)) { | ||
| REPLACE_OP(this_instr, _TO_BOOL_SIZED, 0, 0); | ||
| } |
Contributor
There was a problem hiding this comment.
Would this be better?
PyTypeObject *tp = sym_get_type(value);
if (tp == &PyTuple_Type || tp == ...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion at #148113.
This PR adds two tier2 opcodes for specialization of
TO_BOOL. The*argsand **kwargs` arguments are marked in tier2 as tuple and dict, respectively.In this PR there is no additional type recording or tier1 opcodes, that is left to followup PRs.