Skip to content

gh-148241: Fix json serialization for str subclasses #148249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Apr 9, 2026
Merged

gh-148241: Fix json serialization for str subclasses #148249

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f892cb
gh-148241: Fix json serialization for str subclasses
vstinner Apr 8, 2026
c251659
Add a test to test_json.test_enum
vstinner Apr 8, 2026
fdab889
Reformat tests
vstinner Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test to test_json.test_enum
  • Loading branch information
@vstinner
vstinner committed Apr 8, 2026
commit c251659ee05390615289e7dcb77374508b117a0a
9 changes: 9 additions & 0 deletions Lib/test/test_json/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ class WeirdNum(float, Enum):
neg_inf = NEG_INF
nan = NAN

class StringEnum(str, Enum):
COLOR = "color"

class TestEnum:

def test_floats(self):
Expand Down Expand Up @@ -116,5 +119,11 @@ def test_dict_values(self):
self.assertEqual(nd['j'], NEG_INF)
self.assertTrue(isnan(nd['n']))

def test_str_enum(self):
obj = StringEnum.COLOR
self.assertEqual(self.dumps(obj), '"color"')
self.assertEqual(self.dumps([obj]), '["color"]')
self.assertEqual(self.dumps({'key': obj}), '{"key": "color"}')

class TestPyEnum(TestEnum, PyTest): pass
class TestCEnum(TestEnum, CTest): pass
Loading