Skip to content

gh-148228: Enable error overlays in the REPL #148229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnslavik wants to merge 5 commits into
base: main
Choose a base branch
from
+18 −9
Open

gh-148228: Enable error overlays in the REPL #148229

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86977f9
Enable error overlays
johnslavik Apr 7, 2026
9415f6b
Fix `down` command error reporting bug
johnslavik Apr 7, 2026
62b3577
Fix `test_down_arrow_end_of_input`
johnslavik Apr 7, 2026
50188d3
Fix `test_right_arrow_end_of_line` test
johnslavik Apr 7, 2026
c4b55f2
Merge branch 'main' into enable-error-overlays
johnslavik Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_right_arrow_end_of_line test
  • Loading branch information
@johnslavik
johnslavik committed Apr 7, 2026
commit 50188d301912e1ef08bc90106c7239a8242fd32f
4 changes: 3 additions & 1 deletion Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,15 @@ def test_right_arrow_end_of_line(self):
events = itertools.chain(
code_to_events("11+11"),
[
# Go left first to avoid end of buffer error.
Event(evt="key", data="left", raw=bytearray(b"\x1bOD")),
Event(evt="key", data="right", raw=bytearray(b"\x1bOC")),
],
)

reader, console = handle_all_events(events)
self.assertEqual(reader.cxy, (5, 0))
console.move_cursor.assert_called_once_with(5, 0)
console.move_cursor.assert_called_with(5, 0)

def test_cursor_position_simple_character(self):
events = itertools.chain(code_to_events("k"))
Expand Down
Loading