Skip to content

gh-148178: Validate remote debug offset tables on load #148187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 10 commits into from
Apr 13, 2026
Merged

gh-148178: Validate remote debug offset tables on load #148187

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f6f2faf
gh-148178: Validate remote debug offset tables on load
pablogsal Apr 6, 2026
215390a
Apply suggestions from code review
pablogsal Apr 12, 2026
d3b0fb0
bring back https://github.com/python/cpython/compare/f12f6c4f0467837e…
maurycy Apr 12, 2026
dac7c75
demonstrate the bug?
maurycy Apr 12, 2026
4a5345a
now?
maurycy Apr 12, 2026
0a372d2
fail fast w/ RuntimeError
maurycy Apr 12, 2026
bff8f8a
Revert "bring back https://github.com/python/cpython/compare/f12f6c4f…
maurycy Apr 12, 2026
174853d
Revert "demonstrate the bug?"
maurycy Apr 12, 2026
6657166
Merge pull request #125 from maurycy/maurycy-memcpy-get-member
pablogsal Apr 12, 2026
eccbc15
fixup! Merge pull request #125 from maurycy/maurycy-memcpy-get-member
pablogsal Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "demonstrate the bug?" 
This reverts commit dac7c75.
  • Loading branch information
@maurycy
maurycy committed Apr 12, 2026
commit 174853d2b8e469b4902fd61d1eb13c4c55696a70
31 changes: 0 additions & 31 deletions Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3574,36 +3574,5 @@ def test_get_stats_disabled_raises(self):
client_socket.sendall(b"done")


@requires_remote_subprocess_debugging()
@unittest.skipUnless(sys.platform == "linux", "requires /proc/self/mem")
@unittest.skipIf(
not PROCESS_VM_READV_SUPPORTED,
"Run on Linux with process_vm_readv support",
)
class TestInvalidDebugOffsets(RemoteInspectionTestBase):
@skip_if_not_supported
@unittest.skipUnless(
os.environ.get("PYTHON_REMOTE_DEBUG_UBSAN_PROBE") == "1",
"with UBSan probe",
)
def test_ubsan_probe_misaligned_interpreter_state_id_offset(self):
poison_code = textwrap.dedent(
"""\
interpreter_state_offset = 8 + 8 + 8 + 3 * 8
interpreter_id_offset = interpreter_state_offset + 8
fd = os.open(f"/proc/{pid}/mem", os.O_WRONLY)
os.lseek(fd, addr + interpreter_id_offset, 0)
os.write(fd, struct.pack("<Q", 1))
os.close(fd)
"""
)

with self._poisoned_debug_offsets_process(poison_code) as (_, info):
with self.assertRaisesRegex(RuntimeError, "Invalid debug offsets"):
unwinder = RemoteUnwinder(info["pid"], debug=True)
stack_trace = unwinder.get_stack_trace()
self.assertTrue(stack_trace)


if __name__ == "__main__":
unittest.main()