bpo-37532: email.header.make_header with ascii out of range(128)#14696
Closed
aldwinaldwin wants to merge 2 commits into
Closed
bpo-37532: email.header.make_header with ascii out of range(128)#14696aldwinaldwin wants to merge 2 commits into
ascii out of range(128)#14696aldwinaldwin wants to merge 2 commits into
Conversation
…e is out of range(128)
mangrisano
approved these changes
Jul 11, 2019
Contributor
mangrisano
left a comment
There was a problem hiding this comment.
LGTM. Thank you so much for providing the test :)
Member
Contributor
Author
|
Rejected in bpo: 'The input header is not valid (non-ascii is not allowed in headers), so you shouldn't expect make_header to do anything sensible. Note that this is the legacy API, which is a toolkit and does not hold your hand when it comes to RFC compliance. Aside from any other concerns, this is long standing behavior (it is the same in python2), and it doesn't make sense to change the behavior of a legacy API.' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37532