Skip to content

gh-146558: optimize dict access with objects with known hash #146559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 8 commits into from
Mar 30, 2026
Merged

gh-146558: optimize dict access with objects with known hash #146559

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b441e1b
optimize dict access with objects with safe hash
kumaraditya303 Mar 28, 2026
a5b4476
fix build on windows
kumaraditya303 Mar 28, 2026
3263498
remove benchmark
kumaraditya303 Mar 28, 2026
3af5968
improve comments
kumaraditya303 Mar 28, 2026
7707961
run regen
kumaraditya303 Mar 28, 2026
2d1a169
fix test warning
kumaraditya303 Mar 28, 2026
ea4ae79
optimize floats and complex as well
kumaraditya303 Mar 28, 2026
7a4d046
refactor common code to optimize_dict_known_hash
kumaraditya303 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve comments
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Mar 28, 2026
commit 3af5968873a764f6c2db788dbe3c9fba91f5685b
21 changes: 14 additions & 7 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,23 @@ dummy_func(void) {
PyObject *sub_o = sym_get_const(ctx, sub);
if (sub_o != NULL) {
if (PyUnicode_CheckExact(sub_o) || PyLong_CheckExact(sub_o) || PyBytes_CheckExact(sub_o)) {
// PyObject_Hash can't fail on these types
ADD_OP(_STORE_SUBSCR_DICT_KNOWN_HASH, 0, PyObject_Hash(sub_o));
} else if (PyTuple_CheckExact(sub_o)) {
}
else if (PyTuple_CheckExact(sub_o)) {
// only use known hash variant when hash of tuple is already computed
// since computing it can call arbitrary code
Py_hash_t hash = ((PyTupleObject *)sub_o)->ob_hash;
if (hash != -1) {
ADD_OP(_STORE_SUBSCR_DICT_KNOWN_HASH, 0, hash);
}
} else if (Py_TYPE(sub_o)->tp_hash == PyObject_GenericHash) {
}
else if (Py_TYPE(sub_o)->tp_hash == PyBaseObject_Type.tp_hash) {
// for user-defined objects which don't override tp_hash
Py_hash_t hash = PyObject_Hash(sub_o);
ADD_OP(_STORE_SUBSCR_DICT_KNOWN_HASH, 0, hash);
PyTypeObject *type = Py_TYPE(sub_o);
PyType_Watch(TYPE_WATCHER_ID, (PyObject *)type);
_Py_BloomFilter_Add(dependencies, type);
PyType_Watch(TYPE_WATCHER_ID, Py_TYPE(sub_o));
_Py_BloomFilter_Add(dependencies, Py_TYPE(sub_o));
}
}
(void)value;
Expand Down Expand Up @@ -504,14 +509,16 @@ dummy_func(void) {
if (PyUnicode_CheckExact(sub) || PyLong_CheckExact(sub) || PyBytes_CheckExact(sub)) {
// PyObject_Hash can't fail on these types
ADD_OP(_BINARY_OP_SUBSCR_DICT_KNOWN_HASH, 0, PyObject_Hash(sub));
} else if (PyTuple_CheckExact(sub)) {
}
else if (PyTuple_CheckExact(sub)) {
// only use known hash variant when hash of tuple is already computed
// since computing it can call arbitrary code
Py_hash_t hash = ((PyTupleObject *)sub)->ob_hash;
if (hash != -1) {
ADD_OP(_BINARY_OP_SUBSCR_DICT_KNOWN_HASH, 0, hash);
}
} else if (Py_TYPE(sub)->tp_hash == PyBaseObject_Type.tp_hash) {
}
else if (Py_TYPE(sub)->tp_hash == PyBaseObject_Type.tp_hash) {
// for user-defined objects which don't override tp_hash
Py_hash_t hash = PyObject_Hash(sub);
ADD_OP(_BINARY_OP_SUBSCR_DICT_KNOWN_HASH, 0, hash);
Expand Down
Loading