bpo-37478: Add missing 'and'.#14631
Merged
Merged
Conversation
Member
Author
|
Followup to #14611. |
aeros
reviewed
Jul 7, 2019
Contributor
There was a problem hiding this comment.
@terryjreedy Is "and" appropriate in this case? Based on the discussion in the PR which added the exception description, it seemed like os.chdir() could not not directly raise OSError itself, only its subclasses.
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-14632 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2019
(cherry picked from commit a9b40e4) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-14633 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2019
(cherry picked from commit a9b40e4) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Jul 7, 2019
miss-islington
added a commit
that referenced
this pull request
Jul 7, 2019
Member
Author
|
Yes, Eryk's says it can raise OSError is a situation where none of the subclasses fits. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37478