Skip to content

gh-146308: Fix error handling issues in _remote_debugging module #146309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 3 commits into from
Mar 22, 2026
Merged

gh-146308: Fix error handling issues in _remote_debugging module #146309

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a0560e
gh-146308: Fix error handling issues in _remote_debugging module
pablogsal Mar 22, 2026
ad81c5b
Update Misc/NEWS.d/next/Core_and_Builtins/2026-03-22-19-30-00.gh-issu…
pablogsal Mar 22, 2026
359cf5c
Update Modules/_remote_debugging/binary_io_reader.c
pablogsal Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Modules/_remote_debugging/binary_io_reader.c 
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
  • Loading branch information
@pablogsal @devdanzin
pablogsal and devdanzin authored Mar 22, 2026
commit 359cf5c8ead187f09448846d4468f053cbc4c338
1 change: 1 addition & 0 deletions Modules/_remote_debugging/binary_io_reader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ decode_stack_pop_push(ReaderThreadState *ts, const uint8_t *data,
for (uint32_t i = 0; i < push; i++) {
size_t prev_offset = *offset;
ts->current_stack[i] = decode_varint_u32(data, offset, max_size);
/* If offset didn't advance, varint decoding failed */
if (*offset == prev_offset) {
Comment thread
pablogsal marked this conversation as resolved.
return -1;
}
Expand Down
Loading