Skip to content

gh-146306: Optimize float operations by mutating uniquely-referenced operands in place (JIT only) #146307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 12 commits into from
Mar 24, 2026
Merged

gh-146306: Optimize float operations by mutating uniquely-referenced operands in place (JIT only) #146307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
42d12b7
gh-146306: Optimize float arithmetic in JIT by mutating uniquely-refe…
eendebakpt Mar 22, 2026
637803c
Fix JIT stencil compilation on i686-pc-windows-msvc
eendebakpt Mar 22, 2026
8559fb8
Fix i686 Windows JIT: use x87 FPU instead of SSE for stencils
eendebakpt Mar 22, 2026
7bfdedb
Update Python/bytecodes.c
eendebakpt Mar 24, 2026
c8f860f
Use sym_new_null for consumed operand slots in inplace float ops
eendebakpt Mar 24, 2026
fbedeb3
Revert unrelated bytecodes.c comment/whitespace changes
eendebakpt Mar 24, 2026
1efd764
Merge branch 'main' into jit_float_inplace_rebased
eendebakpt Mar 24, 2026
78c11e1
regenerate
eendebakpt Mar 24, 2026
8af7b51
handle case there operand is set to null
eendebakpt Mar 24, 2026
7d63316
reduce duplication in new opcodes
eendebakpt Mar 24, 2026
c61b9af
review comments
eendebakpt Mar 24, 2026
4ff36c1
cleanup unary opcode
eendebakpt Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review comments
  • Loading branch information
@eendebakpt
eendebakpt committed Mar 24, 2026
commit c61b9af925fe00033f09e92bdff1d68b816e506a
16 changes: 8 additions & 8 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,14 +327,14 @@ dummy_func(void) {
op(_BINARY_OP_ADD_FLOAT, (left, right -- res, l, r)) {
if (PyJitRef_IsUnique(left)) {
ADD_OP(_BINARY_OP_ADD_FLOAT_INPLACE, 0, 0);
l = sym_new_null(ctx);
l = PyJitRef_Borrow(sym_new_null(ctx));
r = right;
}
else if (PyJitRef_IsUnique(right)) {
ADD_OP(_BINARY_OP_ADD_FLOAT_INPLACE_RIGHT, 0, 0);
l = left;
r = sym_new_null(ctx);
}
r = PyJitRef_Borrow(sym_new_null(ctx));
}
else {
l = left;
r = right;
Expand All @@ -345,13 +345,13 @@ dummy_func(void) {
op(_BINARY_OP_SUBTRACT_FLOAT, (left, right -- res, l, r)) {
if (PyJitRef_IsUnique(left)) {
ADD_OP(_BINARY_OP_SUBTRACT_FLOAT_INPLACE, 0, 0);
l = sym_new_null(ctx);
l = PyJitRef_Borrow(sym_new_null(ctx));
r = right;
}
else if (PyJitRef_IsUnique(right)) {
ADD_OP(_BINARY_OP_SUBTRACT_FLOAT_INPLACE_RIGHT, 0, 0);
l = left;
r = sym_new_null(ctx);
r = PyJitRef_Borrow(sym_new_null(ctx));
}
else {
l = left;
Expand All @@ -363,13 +363,13 @@ dummy_func(void) {
op(_BINARY_OP_MULTIPLY_FLOAT, (left, right -- res, l, r)) {
if (PyJitRef_IsUnique(left)) {
ADD_OP(_BINARY_OP_MULTIPLY_FLOAT_INPLACE, 0, 0);
l = sym_new_null(ctx);
l = PyJitRef_Borrow(sym_new_null(ctx));
r = right;
}
else if (PyJitRef_IsUnique(right)) {
ADD_OP(_BINARY_OP_MULTIPLY_FLOAT_INPLACE_RIGHT, 0, 0);
l = left;
r = sym_new_null(ctx);
r = PyJitRef_Borrow(sym_new_null(ctx));
}
else {
l = left;
Expand Down Expand Up @@ -757,7 +757,7 @@ dummy_func(void) {
}

op(_POP_TOP_FLOAT, (value --)) {
if (PyJitRef_IsBorrowed(value) || sym_is_null(value)) {
if (PyJitRef_IsBorrowed(value)) {
ADD_OP(_POP_TOP_NOP, 0, 0);
}
}
Expand Down
14 changes: 7 additions & 7 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading