Skip to content

gh-146151: memoryview supports 'F' and 'D' format types (complex) #146241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Mar 26, 2026
Merged

gh-146151: memoryview supports 'F' and 'D' format types (complex) #146241

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94ee023
gh-146151: memoryview supports 'F' and 'D' format types (complex)
skirpichev Mar 21, 2026
c94450e
Apply suggestions from code review
skirpichev Mar 25, 2026
43e9b18
Merge branch 'master' into support-complex-memoryview/146151
skirpichev Mar 25, 2026
a728a1b
address review: add complex test to test_compare_equal()
skirpichev Mar 25, 2026
f83e88f
Update Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-11-58.gh-issu…
skirpichev Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review: add complex test to test_compare_equal()
  • Loading branch information
@skirpichev
skirpichev committed Mar 25, 2026
commit a728a1badd30f38d7048c03ea0f64ad465d5b0e9
12 changes: 12 additions & 0 deletions Lib/test/test_memoryview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,18 @@ def check_equal(view, is_equal):
m = memoryview(a)
check_equal(m, True)

Comment thread
skirpichev marked this conversation as resolved.
# Test complex formats
for complex_format in 'FD':
with self.subTest(format=complex_format):
data = struct.pack(complex_format * 3, 1.0, 2.0, float('nan'))
m = memoryview(data).cast(complex_format)
# nan is not equal to nan
check_equal(m, False)

data = struct.pack(complex_format * 3, 1.0, 2.0, 3.0)
m = memoryview(data).cast(complex_format)
check_equal(m, True)


class BytesMemorySliceTest(unittest.TestCase,
BaseMemorySliceTests, BaseBytesMemoryTests):
Expand Down
Loading