Skip to content

gh-142186: all-local PEP-669 events #146182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 10 commits into from
Apr 22, 2026
Merged

gh-142186: all-local PEP-669 events #146182

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
07a26bd
Make PY_UNWIND available as a local event
P403n1x87 Dec 2, 2025
1a3e828
break local == instrumented assumption
P403n1x87 Dec 2, 2025
6d743f9
add DISABLE support for PY_UNWIND
P403n1x87 Mar 19, 2026
b5758b3
Make all PEP-669 events local
P403n1x87 Mar 19, 2026
3b8e1d5
rename PY_MONITORING_IS_LOCAL_EVENT -> PY_MONITORING_IS_UNGROUPED_EVENT
P403n1x87 Mar 19, 2026
8fb54fa
fix get_tools_for_instruction
P403n1x87 Mar 20, 2026
958595a
add blurb note
P403n1x87 Mar 23, 2026
7761135
keep local vs other separation
P403n1x87 Apr 18, 2026
5545d46
Merge branch 'main' into gh-142186-pep-669-all-local-events
P403n1x87 Apr 18, 2026
c6d23e9
add whatsnew entry
P403n1x87 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix get_tools_for_instruction
  • Loading branch information
@P403n1x87
P403n1x87 committed Mar 20, 2026
commit 8fb54fa4f499aa4098526ee68ee2ac7e308613b4
12 changes: 10 additions & 2 deletions Python/instrumentation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,10 +1104,18 @@ get_tools_for_instruction(PyCodeObject *code, PyInterpreterState *interp, int i,
}
assert(_PY_MONITORING_IS_UNGROUPED_EVENT(event));
CHECK(debug_check_sanity(interp, code));
if (code->_co_monitoring->tools) {
tools = code->_co_monitoring->tools[i];
if (PY_MONITORING_IS_INSTRUMENTED_EVENT(event)) {
/* Instrumented events use per-instruction tool bitmaps. */
if (code->_co_monitoring->tools) {
tools = code->_co_monitoring->tools[i];
}
else {
tools = code->_co_monitoring->active_monitors.tools[event];
}
}
else {
/* Non-instrumented local events are not tied to specific instructions;
* use the code-object-level active_monitors bitmap instead. */
tools = code->_co_monitoring->active_monitors.tools[event];
Comment thread
P403n1x87 marked this conversation as resolved.
}
return tools;
Expand Down
Loading