Skip to content

gh-145921: Add "_DuringGC" functions for tp_traverse #145925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 15 commits into from
Apr 8, 2026
Merged

gh-145921: Add "_DuringGC" functions for tp_traverse #145925

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
797312f
gh-145921: Add "_DuringGC" functions for tp_traverse
lysnikolaou Mar 13, 2026
01cd8f7
Exclude PyObject_GetItemData_DuringGC from limited ABI
encukou Mar 13, 2026
a94159a
Fix typo in link
encukou Mar 17, 2026
f5a0b07
Move common info to a common section.
encukou Mar 17, 2026
6730065
return m
encukou Mar 17, 2026
1eb82d7
Merge in the main branch
encukou Mar 19, 2026
30a602f
Apply suggestions from code review
encukou Mar 19, 2026
2f74db1
Merge in the GitHub branch
encukou Mar 19, 2026
467ec09
Some more thread safety notes
encukou Mar 19, 2026
9d1386a
Correct function name
encukou Mar 19, 2026
1cb20e6
PyObject_GetItemData: parametrize raising
encukou Mar 19, 2026
bd11e85
What's New entry
encukou Mar 19, 2026
df3bbfe
frogotten git add :/
encukou Mar 19, 2026
ba544d1
Merge branch 'main' into during-gc
encukou Mar 25, 2026
3b40506
Merge branch 'main' into during-gc
encukou Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PyObject_GetItemData: parametrize raising
  • Loading branch information
@encukou
encukou committed Mar 19, 2026
commit 1cb20e6ffe42fb5b160047f48e582c90ff22098e
25 changes: 15 additions & 10 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5995,25 +5995,30 @@ PyType_GetTypeDataSize(PyTypeObject *cls)
return result;
}

void *
PyObject_GetItemData_DuringGC(PyObject *obj)
static inline void
getitemdata(PyObject *obj, bool raise)
{
if (!PyType_HasFeature(Py_TYPE(obj), Py_TPFLAGS_ITEMS_AT_END)) {
if (!_PyType_HasFeature(Py_TYPE(obj), Py_TPFLAGS_ITEMS_AT_END)) {
if (raise) {
PyErr_Format(PyExc_TypeError,
"type '%T' does not have Py_TPFLAGS_ITEMS_AT_END",
obj);
}
return NULL;
}
return (char *)obj + Py_TYPE(obj)->tp_basicsize;
}

void *
PyObject_GetItemData_DuringGC(PyObject *obj)
{
return getitemdata(obj, false);
}

void *
PyObject_GetItemData(PyObject *obj)
{
if (!PyType_HasFeature(Py_TYPE(obj), Py_TPFLAGS_ITEMS_AT_END)) {
PyErr_Format(PyExc_TypeError,
"type '%s' does not have Py_TPFLAGS_ITEMS_AT_END",
Py_TYPE(obj)->tp_name);
return NULL;
}
return PyObject_GetItemData_DuringGC(obj);
return getitemdata(obj, true);
}

/* Internal API to look for a name through the MRO, bypassing the method cache.
Expand Down