Skip to content

[3.14] gh-145376: Fix GC tracking in structseq.__replace__ (GH-145820) #145922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 1 commit into from
Mar 16, 2026
Merged

[3.14] gh-145376: Fix GC tracking in structseq.__replace__ (GH-145820) #145922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-145376: Fix GC tracking in structseq.__replace__ (GH-145820) 
(cherry picked from commit 00a2585)

Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
  • Loading branch information
@eendebakpt @miss-islington
eendebakpt authored and miss-islington committed Mar 13, 2026
commit 84212fd99b307ff8481ab92159c2c85abd851c22
9 changes: 9 additions & 0 deletions Lib/test/test_structseq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import copy
import gc
import os
import pickle
import re
Expand Down Expand Up @@ -355,6 +356,14 @@ def test_reference_cycle(self):
type(t).refcyle = t
"""))

def test_replace_gc_tracked(self):
# Verify that __replace__ results are properly GC-tracked
time_struct = time.gmtime(0)
lst = []
replaced_struct = time_struct.__replace__(tm_year=lst)
lst.append(replaced_struct)

self.assertTrue(gc.is_tracked(replaced_struct))

if __name__ == "__main__":
unittest.main()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-03-11-21-27-28.gh-issue-145376.LfDvyw.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix GC tracking in ``structseq.__replace__()``.
1 change: 1 addition & 0 deletions Objects/structseq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ structseq_replace(PyObject *op, PyObject *args, PyObject *kwargs)
}
}

_PyObject_GC_TRACK(result);
return (PyObject *)result;

error:
Expand Down
Loading