Skip to content

gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 13 commits into from
Mar 31, 2026
+34 −18
Merged

gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fbcec5a
gh-143050: correct PyLong_FromString() to use _PyLong_Negate()
skirpichev Mar 13, 2026
b8333ba
cleanup, use _testcapi.test_immortal_small_ints()
skirpichev Mar 13, 2026
20e79c6
+ add also test with nonzero small int
skirpichev Mar 14, 2026
413e56d
_long_is_small_int() -> _PyLong_IsImmortal() helper
skirpichev Mar 14, 2026
b892216
Merge branch 'master' into fix-PyLong_FromString/143050
skirpichev Mar 17, 2026
78c5b4b
address review: rename _PyLong_IsImmortal -> _PyLong_HasImmortalTag
skirpichev Mar 17, 2026
69d35bd
add assert
skirpichev Mar 18, 2026
2f927e0
address review: simplify assert
skirpichev Mar 18, 2026
53523de
Merge branch 'master' into fix-PyLong_FromString/143050
skirpichev Mar 27, 2026
1f363f4
address review: some comments
skirpichev Mar 28, 2026
41961ed
Merge branch 'main' into fix-PyLong_FromString/143050
skirpichev Mar 30, 2026
0b29e28
address review: add assert on _PY_IS_SMALL_INT
skirpichev Mar 30, 2026
45b3b04
Rename to _PyLong_IsSmallInt()
vstinner Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename to _PyLong_IsSmallInt() 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
  • Loading branch information
@vstinner @skirpichev
vstinner and skirpichev authored Mar 31, 2026
commit 45b3b040da09b93a42a32e71f08de5670f8d79d6
4 changes: 2 additions & 2 deletions Include/internal/pycore_long.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ _PyLong_IsPositive(const PyLongObject *op)

/* Return true if the argument is a small int */
static inline bool
Comment thread
skirpichev marked this conversation as resolved.
_PyLong_HasImmortalTag(const PyLongObject *op)
_PyLong_IsSmallInt(const PyLongObject *op)
{
assert(PyLong_Check(op));
bool is_small_int = (op->long_value.lv_tag & IMMORTALITY_BIT_MASK) != 0;
Expand Down Expand Up @@ -309,7 +309,7 @@ _PyLong_SetDigitCount(PyLongObject *op, Py_ssize_t size)
static inline void
_PyLong_FlipSign(PyLongObject *op)
{
assert(!_PyLong_HasImmortalTag(op));
assert(!_PyLong_IsSmallInt(op));
unsigned int flipped_sign = 2 - (op->long_value.lv_tag & SIGN_MASK);
op->long_value.lv_tag &= NON_SIZE_MASK;
op->long_value.lv_tag |= flipped_sign;
Expand Down
4 changes: 2 additions & 2 deletions Modules/_testcapi/immortal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ test_immortal_small_ints(PyObject *self, PyObject *Py_UNUSED(ignored))
for (int i = -5; i <= 1024; i++) {
PyObject *obj = PyLong_FromLong(i);
assert(verify_immortality(obj));
int has_int_immortal_bit = _PyLong_HasImmortalTag((PyLongObject *)obj);
int has_int_immortal_bit = _PyLong_IsSmallInt((PyLongObject *)obj);
assert(has_int_immortal_bit);
}
for (int i = 1025; i <= 1030; i++) {
PyObject *obj = PyLong_FromLong(i);
assert(obj);
int has_int_immortal_bit = _PyLong_HasImmortalTag((PyLongObject *)obj);
int has_int_immortal_bit = _PyLong_IsSmallInt((PyLongObject *)obj);
assert(!has_int_immortal_bit);
Py_DECREF(obj);
}
Expand Down
4 changes: 2 additions & 2 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3627,7 +3627,7 @@ void
_PyLong_ExactDealloc(PyObject *self)
{
assert(PyLong_CheckExact(self));
if (_PyLong_HasImmortalTag((PyLongObject *)self)) {
if (_PyLong_IsSmallInt((PyLongObject *)self)) {
// See PEP 683, section Accidental De-Immortalizing for details
_Py_SetImmortal(self);
return;
Expand All @@ -3642,7 +3642,7 @@ _PyLong_ExactDealloc(PyObject *self)
static void
long_dealloc(PyObject *self)
{
if (_PyLong_HasImmortalTag((PyLongObject *)self)) {
if (_PyLong_IsSmallInt((PyLongObject *)self)) {
/* This should never get called, but we also don't want to SEGV if
* we accidentally decref small Ints out of existence. Instead,
* since small Ints are immortal, re-set the reference count.
Expand Down
Loading