Skip to content

gh-138122: Add differential flame graph #145785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 14 commits into from
Mar 30, 2026
Merged

gh-138122: Add differential flame graph #145785

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
65528db
Add differential flame graph
ivonastojanovic Mar 8, 2026
2d97700
Add news
ivonastojanovic Mar 10, 2026
6e642e4
Fix colors
ivonastojanovic Mar 26, 2026
37289cb
Show diff in ms
ivonastojanovic Mar 26, 2026
edaac9f
Refactor active flamegraph data retrieval
ivonastojanovic Mar 26, 2026
c2203d6
Improve tests
ivonastojanovic Mar 27, 2026
afe2f4e
Change removed functions color
ivonastojanovic Mar 27, 2026
c0d937f
Fix opcode merging in inverted flamegraph view
ivonastojanovic Mar 29, 2026
080d2c8
fixup! Improve tests
ivonastojanovic Mar 29, 2026
440d333
Merge branch 'main' into differential_flamegraph
ivonastojanovic Mar 29, 2026
f4928b9
Update Lib/profiling/sampling/stack_collector.py
pablogsal Mar 29, 2026
5556396
Update Lib/profiling/sampling/stack_collector.py
picnixz Mar 29, 2026
d515f73
Random fixes
pablogsal Mar 29, 2026
f753071
Small fix to cli
pablogsal Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Show diff in ms 
Since baseline and current self time are shown in ms, the diff
should also be displayed in ms instead of samples.
  • Loading branch information
@ivonastojanovic
ivonastojanovic committed Mar 26, 2026
commit 37289cb00dc9be48d58521a495472f90a87211c1
8 changes: 4 additions & 4 deletions Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,10 @@ function createPythonTooltip(data) {
if (d.data.diff !== undefined && d.data.baseline !== undefined) {
const baselineSelf = (d.data.baseline / 1000).toFixed(2);
const currentSelf = ((d.data.self_time || 0) / 1000).toFixed(2);
const diffSamples = d.data.diff;
const diffMs = (d.data.diff / 1000).toFixed(2);
const diffPct = d.data.diff_pct;
const sign = diffSamples >= 0 ? "+" : "";
const diffClass = diffSamples > 0 ? "regression" : (diffSamples < 0 ? "improvement" : "neutral");
const sign = d.data.diff >= 0 ? "+" : "";
const diffClass = d.data.diff > 0 ? "regression" : (d.data.diff < 0 ? "improvement" : "neutral");

diffSection = `
<div class="tooltip-diff">
Expand All @@ -365,7 +365,7 @@ function createPythonTooltip(data) {
</div>
<div class="tooltip-diff-row ${diffClass}">
<span class="tooltip-stat-label">Difference:</span>
<span class="tooltip-stat-value">${sign}${diffSamples.toFixed(1)} samples (${sign}${diffPct.toFixed(1)}%)</span>
<span class="tooltip-stat-value">${sign}${diffMs} ms (${sign}${diffPct.toFixed(1)}%)</span>
</div>
</div>`;
}
Expand Down