Skip to content

gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format #145756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 8 commits into from
Mar 20, 2026
+11 −1
Merged

gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format #145756

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1342951
`unittest.mock`: Update signature retrieval to use `String` annotatio…
mschoettle Mar 10, 2026
d64ded3
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 10, 2026
ae68a42
use forwardref instead
mschoettle Mar 10, 2026
71caad2
fix backticks in news entry
mschoettle Mar 10, 2026
5d9a394
add test
mschoettle Mar 10, 2026
569deb2
Apply suggestions from code review
mschoettle Mar 19, 2026
78ec3dd
Merge branch 'python:main' into patch-1
mschoettle Mar 19, 2026
a5989fd
clean up
mschoettle Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@mschoettle
mschoettle committed Mar 10, 2026
commit 5d9a3945d89b827e51f78a1a4a14418d0065dfa8
11 changes: 11 additions & 0 deletions Lib/test/test_unittest/testmock/testmock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,6 +1743,17 @@ def static_method(): pass
mock_method.assert_called_once_with()
self.assertRaises(TypeError, mock_method, 'extra_arg')

#Issue145754
Comment thread
mschoettle marked this conversation as resolved.
Outdated
def test_create_autospec_type_hints_typechecking(self):
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from typing import Tuple
Comment thread
mschoettle marked this conversation as resolved.
Outdated

def foo(x: Tuple[int, ...]) -> None:
pass

mock.create_autospec(foo)

#Issue21238
def test_mock_unsafe(self):
m = Mock()
Expand Down
Loading