Skip to content

gh-145681: do not deallocate list buffer in _PyList_AsTupleAndClear #145680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 3 commits into from
Mar 12, 2026
+0 −2
Merged

gh-145681: do not deallocate list buffer in _PyList_AsTupleAndClear #145680

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a4d8b8
fix: reset list allocated to 0
KowalskiThomas Mar 9, 2026
22cc928
refactor: only use SET_SIZE, don't touch buffer metadata
KowalskiThomas Mar 11, 2026
6fe0c5c
fix: do not call free_list_items
KowalskiThomas Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: reset list allocated to 0
  • Loading branch information
@KowalskiThomas
KowalskiThomas committed Mar 9, 2026
commit 5a4d8b8a198e18d01f2e0d5b75568cfd17acfa6e
1 change: 1 addition & 0 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3260,6 +3260,7 @@ _PyList_AsTupleAndClear(PyListObject *self)
Py_ssize_t size = Py_SIZE(self);
self->ob_item = NULL;
Py_SET_SIZE(self, 0);
self->allocated = 0;
Copy link
Copy Markdown
Contributor

@sergey-miryanov sergey-miryanov Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list_clear_impl has extra code if Py_GIL_DISABLED - should we include it here?

Copy link
Copy Markdown
Contributor Author

@KowalskiThomas KowalskiThomas Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, there is a discussion on the issue right now but I'll keep that in mind when time comes.

ret = _PyTuple_FromArraySteal(items, size);
free_list_items(items, false);
Py_END_CRITICAL_SECTION();
Expand Down
Loading