Skip to content

gh-145376: Fix various refleaks Objects/ #145609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 10 commits into from
Mar 9, 2026
Merged

gh-145376: Fix various refleaks Objects/ #145609

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
577de24
Fix refleak in binascii.c
eendebakpt Mar 5, 2026
e4fa631
Fix refleak in _cursesmodule.c
eendebakpt Mar 6, 2026
efb497b
Fix refleak in object.c
eendebakpt Mar 6, 2026
c9d5cac
Fix refleak in genericaliasobject.c
eendebakpt Mar 6, 2026
3bafd1a
Fix refleak in typevarobject.c
eendebakpt Mar 6, 2026
f0e38ea
Fix decref on null in structseq.c
eendebakpt Mar 6, 2026
de71a74
Fix refleak in Objects/unicodeobject.c
eendebakpt Mar 6, 2026
b128a9d
missing commit
eendebakpt Mar 6, 2026
a337697
review comment
eendebakpt Mar 6, 2026
eadf7a1
review comment
eendebakpt Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix refleak in _cursesmodule.c
  • Loading branch information
@eendebakpt
eendebakpt committed Mar 6, 2026
commit e4fa631adcccd4de1411d4345fa8213602a64946
3 changes: 3 additions & 0 deletions Modules/_cursesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,7 @@ _curses_window_addstr_impl(PyCursesWindowObject *self, int group_left_1,
attr_old = getattrs(self->win);
if (curses_wattrset(self, attr, "addstr") < 0) {
curses_release_wstr(strtype, wstr);
Py_DECREF(bytesobj);
Copy link
Copy Markdown
Member

@picnixz picnixz Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful here. PyCurses_ConvertToString has a weird return type so you might not necessarily have bytesobj set to something (it might be in wstr instead).

Copy link
Copy Markdown
Contributor Author

@eendebakpt eendebakpt Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

return NULL;
}
}
Expand Down Expand Up @@ -1210,6 +1211,7 @@ _curses_window_addnstr_impl(PyCursesWindowObject *self, int group_left_1,
attr_old = getattrs(self->win);
if (curses_wattrset(self, attr, "addnstr") < 0) {
curses_release_wstr(strtype, wstr);
Py_DECREF(bytesobj);
return NULL;
}
}
Expand Down Expand Up @@ -2212,6 +2214,7 @@ _curses_window_insstr_impl(PyCursesWindowObject *self, int group_left_1,
attr_old = getattrs(self->win);
if (curses_wattrset(self, attr, "insstr") < 0) {
curses_release_wstr(strtype, wstr);
Py_DECREF(bytesobj);
return NULL;
}
}
Expand Down