Skip to content

gh-145568: Fix thread safety in Modules/_elementtree.c for free-threaded build #145569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sebcio03 wants to merge 2 commits into from
Closed

gh-145568: Fix thread safety in Modules/_elementtree.c for free-threaded build #145569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79eeccb
gh-NNNNN: Fix thread safety in Modules/_elementtree.c for free-thread…
Mar 5, 2026
41048a9
gh-145568: rename NEWS entry and expand description
Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
gh-145568: rename NEWS entry and expand description 
Replace placeholder gh-issue-NNNNN with the real issue number 145568.
Expand the NEWS text to cover all 7 areas fixed by the parent commit
(struct-field races, child-list mutations, property getters/setters,
__copy__, __deepcopy__, TreeBuilder end-tag handling, and the
borrowed-reference fix in the expat entity handler).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
Sebastian Ozimkowski @claude
Sebastian Ozimkowski and claude committed Mar 5, 2026
commit 41048a9c114ad9ae5ccc916c59b9ee71e349aecc
12 changes: 12 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-05-17-45-00.gh-issue-145568.1LHFaD2C.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Fix multiple data races in :mod:`xml.etree.ElementTree` for the free-threaded
build. Add :c:macro:`Py_BEGIN_CRITICAL_SECTION` guards and ``_lock_held``
split-function patterns throughout ``Modules/_elementtree.c`` to protect
:class:`~xml.etree.ElementTree.Element` struct fields, child-list mutations
(:meth:`~xml.etree.ElementTree.Element.append`,
:meth:`~xml.etree.ElementTree.Element.insert`,
:meth:`~xml.etree.ElementTree.Element.clear`), property
getters/setters, :meth:`~xml.etree.ElementTree.Element.__copy__`,
:meth:`~xml.etree.ElementTree.Element.__deepcopy__`, and
:class:`~xml.etree.ElementTree.TreeBuilder` end-tag handling.
Also replace a :c:func:`PyDict_GetItemWithError` borrowed-reference lookup
in the expat entity handler with :c:func:`PyDict_GetItemRef`.
5 changes: 0 additions & 5 deletions Misc/NEWS.d/next/Library/2026-03-05-17-45-00.gh-issue-NNNNN.1LHFaD2C.rst
View file
Open in desktop

This file was deleted.

Loading