gh-135683: Ensure that WatchedFileHandler calls handleError on exceptions.#145246
Open
vsajip wants to merge 2 commits into
Open
gh-135683: Ensure that WatchedFileHandler calls handleError on exceptions.#145246vsajip wants to merge 2 commits into
vsajip wants to merge 2 commits into
Conversation
|
🤖 New build scheduled with the buildbot fleet by @vsajip for commit 33a9869 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145246%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
picnixz
reviewed
Mar 21, 2026
Comment on lines
+1260
to
+1263
| try: | ||
| self.stream = self._open() | ||
| except Exception: | ||
| self.handleError(record) |
Member
There was a problem hiding this comment.
Very silly but I wonder whether a possible AttributeErrorn raised when _open() is missing should be handled or not. Maybe we should only catch the exception when doing:
do_open = self._open
try:
stream = do_open()
except Exception:
self.handleError(record)
else:
self._stream = stream
Or do you think it makes sense to let exceptions happening when setting the field and accessing _open() being handled normally?
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.