Skip to content

gh-131798: Split CHECK_FUNCTION_VERSION into two guards in the JIT #145080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sacul0457 wants to merge 11 commits into
base: main
Choose a base branch
from
Open

gh-131798: Split CHECK_FUNCTION_VERSION into two guards in the JIT #145080

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebcc043
Split CHECK_FUNCTION_VERSION into two guards
Sacul0457 Feb 21, 2026
481ad4b
address review and add assert
Sacul0457 Feb 25, 2026
e775a6b
Attempting to fix merge conflicts...
Sacul0457 Feb 25, 2026
7c62059
Merge branch 'main' into Split-up-CHECK_FUNCTION_VERSION
Sacul0457 Mar 13, 2026
86c929d
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 13, 2026
99cbd72
regen files
Sacul0457 Mar 13, 2026
0a3a178
Merge branch 'Split-up-CHECK_FUNCTION_VERSION' of https://github.com/…
Sacul0457 Mar 13, 2026
f58adeb
fix lint
Sacul0457 Mar 13, 2026
aa03bc0
change to assert
Sacul0457 Mar 13, 2026
40d2eaa
Merge branch 'main' into Split-up-CHECK_FUNCTION_VERSION
Sacul0457 Mar 21, 2026
f7a5f30
regen files
Sacul0457 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change to assert
  • Loading branch information
@Sacul0457
Sacul0457 committed Mar 13, 2026
commit aa03bc0b44e931595cc335a907377374e09006a1
3 changes: 2 additions & 1 deletion Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,8 @@ dummy_func(void) {
}

op(_CHECK_FUNCTION_VERSION, (func_version/2, callable, self_or_null, unused[oparg] -- callable, self_or_null, unused[oparg])) {
if (sym_is_const(ctx, callable) && sym_matches_type(callable, &PyFunction_Type)) {
assert(sym_matches_type(callable, &PyFunction_Type));
if (sym_is_const(ctx, callable)) {
assert(PyFunction_Check(sym_get_const(ctx, callable)));
ADD_OP(_CHECK_FUNCTION_VERSION_INLINE, 0, func_version);
uop_buffer_last(&ctx->out_buffer)->operand1 = (uintptr_t)sym_get_const(ctx, callable);
Expand Down
3 changes: 2 additions & 1 deletion Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading