Skip to content

gh-145056: Let dict specific tests accept frozendict as well #145060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhettinger wants to merge 3 commits into from
Closed

gh-145056: Let dict specific tests accept frozendict as well #145060

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f27f128
gh-145056: Let dict specific tests accept frozendict as well
rhettinger Feb 21, 2026
4d02992
Add tests
rhettinger Feb 21, 2026
a887273
Expand the fast path in the C version of OrderedDict
rhettinger Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-145056: Let dict specific tests accept frozendict as well
  • Loading branch information
@rhettinger
rhettinger committed Feb 21, 2026
commit f27f128ab9ddcecee092e4f9ff61b9f95b2d505d
8 changes: 4 additions & 4 deletions Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,14 +328,14 @@ def __ior__(self, other):
return self

def __or__(self, other):
if not isinstance(other, dict):
if not isinstance(other, (dict, frozendict)):
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the C implementation?

Copy link
Copy Markdown
Contributor Author

@rhettinger rhettinger Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C version already supported any mapping input, that is how the tests passed. But I will update the fast path to use PyAnyDict_CheckExact(arg).

return NotImplemented
new = self.__class__(self)
new.update(other)
return new

def __ror__(self, other):
if not isinstance(other, dict):
if not isinstance(other, (dict, frozendict)):
return NotImplemented
new = self.__class__(other)
new.update(self)
Expand Down Expand Up @@ -1221,14 +1221,14 @@ def __repr__(self):
def __or__(self, other):
if isinstance(other, UserDict):
return self.__class__(self.data | other.data)
if isinstance(other, dict):
if isinstance(other, (dict, frozendict)):
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests for this?

Copy link
Copy Markdown
Contributor Author

@rhettinger rhettinger Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't see where the dict version was tested so left this alone.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very bad. We need to add tests with dict first.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let's leave this. There are many other missing tests for UserDict and UserList. I am working on this.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#145145 will add new tests. Now there will be a place for new frozendict tests.

return self.__class__(self.data | other)
return NotImplemented

def __ror__(self, other):
if isinstance(other, UserDict):
return self.__class__(other.data | self.data)
if isinstance(other, dict):
if isinstance(other, (dict, frozendict)):
return self.__class__(other | self.data)
return NotImplemented

Expand Down
Loading