Skip to content

gh-143300: implement PyUnstable_SetImmortal #144543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 11 commits into from
Feb 11, 2026
Merged

gh-143300: implement PyUnstable_SetImmortal #144543

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b874f0b
implement PyUnstable_SetImmortal
kumaraditya303 Feb 6, 2026
cb6cc99
fix compilation under ft
kumaraditya303 Feb 6, 2026
c897a08
minor fixes
kumaraditya303 Feb 7, 2026
f00e23f
Apply suggestions from code review
kumaraditya303 Feb 10, 2026
f42377a
address review
kumaraditya303 Feb 10, 2026
ed5389c
Merge branch 'main' into immortal
kumaraditya303 Feb 10, 2026
9987a92
add more tests
kumaraditya303 Feb 10, 2026
9a4003c
fix test on ft
kumaraditya303 Feb 10, 2026
8fe0fb5
fix lint
kumaraditya303 Feb 10, 2026
a146bef
address final review
kumaraditya303 Feb 11, 2026
e1ef13d
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more tests
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Feb 10, 2026
commit 9987a92ec5d2b60c442b367a81b493d42d75d8ad
15 changes: 14 additions & 1 deletion Modules/_testcapi/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,23 @@ test_py_set_immortal(PyObject *self, PyObject *unused)
Py_SET_REFCNT(&object, 1);
Py_SET_TYPE(&object, &PyBaseObject_Type);
assert(!PyUnstable_IsImmortal(&object));
PyUnstable_SetImmortal(&object);
int rc = PyUnstable_SetImmortal(&object);
assert(rc == 1);
assert(PyUnstable_IsImmortal(&object));
Py_DECREF(&object); // should not dealloc
assert(PyUnstable_IsImmortal(&object));

// Check already immortal object
rc = PyUnstable_SetImmortal(&object);
assert(rc == 0);

// Check unicode objects
PyObject *unicode = PyUnicode_FromString("test");
assert(!PyUnstable_IsImmortal(unicode));
rc = PyUnstable_SetImmortal(unicode);
assert(rc == 0);
assert(!PyUnstable_IsImmortal(unicode));
Py_DECREF(unicode);
Py_RETURN_NONE;
}

Expand Down
Loading