gh-144148: Update the urllib.parse documentation#144497
Conversation
|
You should update test_urlparse. Example: |
Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.
34b476b to
5f36382
Compare
|
Sorry, I forget to save the last changes before committing. And did not run the tests. |
orsenthil
left a comment
There was a problem hiding this comment.
LGTM. It is a clear and the intention comes across correct at the very high level.
|
I force-pushed that change because I had not noticed that Victor already started review. |
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
For the 3.14 backport, I'm not sure that it's a good idea to change deprecation messages. Would it be possible to leave deprecation messages unchanged for the backport?
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
…GH-144497) Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-144507 is a backport of this pull request to the 3.14 branch. |
…GH-144497) (pythonGH-144507) (cherry picked from commit 2fb9cde) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Document urlsplit() as the main parsing function and urlparse() as an obsolete variant. (cherry picked from commit 67ddba9)
|
|
Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.
Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.
Document urlsplit() as the main parsing function and urlparse() as an obsolete variant.
📚 Documentation preview 📚: https://cpython-previews--144497.org.readthedocs.build/