Skip to content

gh-142516: fix reference leaks in ssl.SSLContext objects #143685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 6 commits into from
Feb 21, 2026
Merged

gh-142516: fix reference leaks in ssl.SSLContext objects #143685

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfca05f
gh-142516: fix reference leaks in `ssl.SSLContext` objects
picnixz Jan 11, 2026
ba02a26
test! add regression tests
picnixz Jan 11, 2026
6b08305
chore! NEWS entry
picnixz Jan 11, 2026
57d4fba
fix tests on Windows
picnixz Jan 11, 2026
9083a84
Merge branch 'main' into fix/ssl/leak-gc-142516
picnixz Feb 7, 2026
02226ce
post-merge
picnixz Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests on Windows
  • Loading branch information
@picnixz
picnixz committed Jan 11, 2026
commit 57d4fba0a0cf585bf3c989c6e54f2578e44aef8f
8 changes: 7 additions & 1 deletion Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
HAS_KEYLOG = hasattr(ssl.SSLContext, 'keylog_filename')
requires_keylog = unittest.skipUnless(
HAS_KEYLOG, 'test requires OpenSSL 1.1.1 with keylog callback')
CAN_SET_KEYLOG = HAS_KEYLOG and os.name != "nt"
requires_keylog_setter = unittest.skipUnless(
CAN_SET_KEYLOG,
"cannot set 'keylog_filename' on Windows"
)


PROTOCOL_TO_TLS_VERSION = {}
for proto, ver in (
Expand Down Expand Up @@ -1777,7 +1783,7 @@ def msg_callback(*args, _=ctx, **kwargs): ...
ctx._msg_callback = msg_callback

@support.cpython_only
@requires_keylog
@requires_keylog_setter
def test_refcycle_keylog_filename(self):
# See https://github.com/python/cpython/issues/142516.
self.addCleanup(os_helper.unlink, os_helper.TESTFN)
Expand Down
Loading