Skip to content

gh-143237: Fix support of named pipes in the rotating logging handlers #143259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Dec 30, 2025
Merged

gh-143237: Fix support of named pipes in the rotating logging handlers #143259

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc46702
gh-143237: Fix support of named pipes in the rotating logging handlers
serhiy-storchaka Dec 28, 2025
9d97701
Use contextlib.closing.
serhiy-storchaka Dec 30, 2025
cfa5a05
Merge branch 'main' into logging-rotate-named-file
serhiy-storchaka Dec 30, 2025
a9f312e
Test also that it works with a named pipe at all.
serhiy-storchaka Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use contextlib.closing.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 30, 2025
commit 9d97701beaf38b66ae4ca20558dbbcc457c543be
5 changes: 2 additions & 3 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import codecs
import configparser
import contextlib
import copy
import datetime
import pathlib
Expand Down Expand Up @@ -6387,10 +6388,8 @@ def other_side():
with threading_helper.start_threads([thread]):
rh = logging.handlers.RotatingFileHandler(
filename, encoding="utf-8", maxBytes=1)
try:
with contextlib.closing(rh):
self.assertFalse(rh.shouldRollover(self.next_rec()))
finally:
rh.close()

def test_should_rollover(self):
with open(self.fn, 'wb') as f:
Expand Down