Skip to content

Delete mention encoding for importlib.resources.path#143111

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
shadchin:patch-3
Jun 6, 2026
Merged

Delete mention encoding for importlib.resources.path#143111
serhiy-storchaka merged 2 commits into
python:mainfrom
shadchin:patch-3

Conversation

@shadchin
Copy link
Copy Markdown
Contributor

@shadchin shadchin commented Dec 23, 2025 •
edited by github-actions Bot
Loading

importlib.resources.path does not have an encoding argument

📚 Documentation preview 📚: https://cpython-previews--143111.org.readthedocs.build/

@shadchin
Delete mention encoding for importlib.resources.path
5047428 
`importlib.resources.path` does not have an `encoding` argument
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 23, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Dec 23, 2025
@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Jan 4, 2026

gentle ping)

@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Jan 19, 2026

@jaraco Can you take a look?

@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Jan 29, 2026

@warsaw Can you take a look?

warsaw
warsaw approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shadchin, this looks like a good catch to me. I'll approve and we can land that here. I'd like @jaraco to comment on whether this needs to be cross-ported to importlib_resources.

@warsaw warsaw added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 30, 2026
@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Feb 24, 2026

@jaraco Can you take a look?

@shadchin
Copy link
Copy Markdown
Contributor Author

shadchin commented Apr 27, 2026

ping

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jun 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

This was probably a copying error from open_text or read_text.

@serhiy-storchaka serhiy-storchaka merged commit fded34d into python:main Jun 6, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 6, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 6, 2026

Thanks @shadchin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151014 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 6, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151015 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 6, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 6, 2026

GH-151016 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 6, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @shadchin
[3.13] Delete mention encoding and errors for importlib.resources.pat…
8a69d89 
…h() (GH-143111) (GH-151016)

(cherry picked from commit fded34d)

Co-authored-by: Alexander Shadchin <shadchin@yandex-team.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @shadchin
[3.14] Delete mention encoding and errors for importlib.resources.pat…
3017037 
…h() (GH-143111) (GH-151015)

(cherry picked from commit fded34d)

Co-authored-by: Alexander Shadchin <shadchin@yandex-team.com>
serhiy-storchaka pushed a commit that referenced this pull request Jun 6, 2026
@miss-islington @shadchin
[3.15] Delete mention encoding and errors for importlib.resources.pat…
3c1c9ba 
…h() (GH-143111) (GH-151014)

(cherry picked from commit fded34d)

Co-authored-by: Alexander Shadchin <shadchin@yandex-team.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news topic-importlib

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shadchin @warsaw @serhiy-storchaka @StanFromIreland