Skip to content

gh-74902: Add Unicode Grapheme Cluster Break algorithm #143076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 10 commits into from
Jan 14, 2026
Merged

gh-74902: Add Unicode Grapheme Cluster Break algorithm #143076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c1bd42
gh-74902: Add Unicode Grapheme Cluster Break algorithm
serhiy-storchaka Dec 21, 2025
b0585f9
Try to fix rst.
serhiy-storchaka Dec 22, 2025
37fa38f
iConvert the types to heap types.
serhiy-storchaka Dec 23, 2025
c46e9bd
Update Doc/library/unicodedata.rst
serhiy-storchaka Dec 23, 2025
22cacf6
Apply suggestions from code review
serhiy-storchaka Dec 26, 2025
a95c3cb
Add tests for GB12 and GB13. Remove redundant parameter in run_graphe…
serhiy-storchaka Dec 26, 2025
ad50831
Rename Grapheme to Segment. Add __repr__(), remove __iter__().
serhiy-storchaka Dec 26, 2025
365d0c1
Merge branch 'main' into grapheme_cluster_break2
serhiy-storchaka Jan 2, 2026
f96c8d0
Merge branch 'main' into grapheme_cluster_break2
serhiy-storchaka Jan 14, 2026
3b3a50a
Polishing.
serhiy-storchaka Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for GB12 and GB13. Remove redundant parameter in run_graphe… 
…me_break_tests().
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 26, 2025
commit a95c3cb0209b30c93012a02269a921492f29a6a6
15 changes: 10 additions & 5 deletions Lib/test/test_unicodedata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,9 +822,14 @@ def graphemes(*args):
'\u200D\U0001F48B\u200D\U0001F9D1\U0001F3FC'),
['\U0001F9D1\U0001F3FE\u200D\u2764\uFE0F'
'\u200D\U0001F48B\u200D\U0001F9D1\U0001F3FC'])
# GB11
self.assertEqual(graphemes('\U0001F1FA\U0001F1E6'),
['\U0001F1FA\U0001F1E6'])
# GB12
self.assertEqual(graphemes(
'\U0001F1FA\U0001F1E6\U0001F1FA\U0001F1F3'),
['\U0001F1FA\U0001F1E6', '\U0001F1FA\U0001F1F3'])
# GB13
self.assertEqual(graphemes(
'a\U0001F1FA\U0001F1E6\U0001F1FA\U0001F1F3'),
['a', '\U0001F1FA\U0001F1E6', '\U0001F1FA\U0001F1F3'])


class Unicode_3_2_0_FunctionsTest(UnicodeFunctionsTest):
Expand Down Expand Up @@ -1085,9 +1090,9 @@ def test_grapheme_break(self):
self.skipTest(f"Failed to download {TESTDATAURL}: {exc}")

with testdata:
self.run_grapheme_break_tests(testdata, unicodedata)
self.run_grapheme_break_tests(testdata)

def run_grapheme_break_tests(self, testdata, ucd):
def run_grapheme_break_tests(self, testdata):
for line in testdata:
line, _, comment = line.partition('#')
line = line.strip()
Expand Down
7 changes: 4 additions & 3 deletions Modules/unicodedata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,9 +1773,9 @@ grapheme_break(int prev_gcb, int curr_gcb, enum ExtPictState ep_state,
/* GB6 */
if (prev_gcb == GCB_L &&
(curr_gcb == GCB_L ||
curr_gcb == GCB_V ||
curr_gcb == GCB_LV ||
curr_gcb == GCB_LVT))
curr_gcb == GCB_V ||
curr_gcb == GCB_LV ||
curr_gcb == GCB_LVT))
{
return false;
}
Expand Down Expand Up @@ -1819,6 +1819,7 @@ grapheme_break(int prev_gcb, int curr_gcb, enum ExtPictState ep_state,
return false;
}

/* GB12 and GB13 */
if (prev_gcb == GCB_Regional_Indicator && curr_gcb == prev_gcb) {
return ri_flag;
}
Expand Down