Skip to content

GH-134584: Remove redundant refcount for BINARY_OP_SUBSCR_STR_INT #142844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 6 commits into from
Dec 18, 2025
Merged

GH-134584: Remove redundant refcount for BINARY_OP_SUBSCR_STR_INT #142844

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f6d542
Remove refcount for BINARY_OP_SUBSCR_STR_INT
savannahostrowski Dec 16, 2025
4aa025a
Fix order
savannahostrowski Dec 16, 2025
7df6592
Regen
savannahostrowski Dec 16, 2025
452aa97
lint
savannahostrowski Dec 16, 2025
4692cbf
Merge branch 'main' into binary-op-subscr-str-int
savannahostrowski Dec 16, 2025
15bd11d
Merge main
savannahostrowski Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix order
  • Loading branch information
@savannahostrowski
savannahostrowski committed Dec 16, 2025
commit 4aa025a49b11c5bcfeea3cc4c008ba94da5de9c0
2 changes: 1 addition & 1 deletion Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ dummy_func(
}

macro(BINARY_OP_SUBSCR_STR_INT) =
_GUARD_TOS_INT + _GUARD_NOS_UNICODE + unused/5 + _BINARY_OP_SUBSCR_STR_INT + POP_TOP + _POP_TOP_INT;
_GUARD_TOS_INT + _GUARD_NOS_UNICODE + unused/5 + _BINARY_OP_SUBSCR_STR_INT + POP_TOP_INT + POP_TOP;

op(_BINARY_OP_SUBSCR_STR_INT, (str_st, sub_st -- res, s, i)) {
PyObject *sub = PyStackRef_AsPyObjectBorrow(sub_st);
Expand Down