Skip to content

gh-140550: Update xxlimited with 3.15 limited API & PEP 697 #142827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
encukou wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-140550: Update xxlimited with 3.15 limited API & PEP 697 #142827

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8147b92
Copy xxlimited to xxlimited_3_13
encukou Dec 15, 2025
65f3fd0
Run tests for all the xxlimited* modules
encukou Dec 15, 2025
aa43538
Adjust module names in the 3_13 module
encukou Dec 15, 2025
323695f
Update xxlimited to 3.15 limited API (with opaque PyObject)
encukou Dec 15, 2025
597652b
Comments & cleanups
encukou Dec 16, 2025
22464eb
Add Py_mod_abi
encukou Dec 16, 2025
cc5e8f3
Remove unused import
encukou Dec 16, 2025
945b450
Don't flag static PyABIInfo variables
encukou Dec 16, 2025
3b3ae7c
Refcounting fix
encukou Dec 17, 2025
ff0f300
Style
encukou Dec 17, 2025
29f1690
Expand TODO
encukou Dec 17, 2025
d9728de
Remove comment that might be misleading
encukou Dec 17, 2025
0bc0198
PyUnicode_EqualToUTF8 can't error (and doesn't type-check)
encukou Dec 17, 2025
0ae6c58
Merge in the main branch
encukou Apr 8, 2026
619eac7
Use _DuringGC API in traversal functions
encukou Apr 8, 2026
d680b17
Don't clobber current exception in tp_dealloc
encukou Apr 8, 2026
38e5fea
Avoid data race in Xxo_setattro
encukou Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run tests for all the xxlimited* modules
  • Loading branch information
@encukou
encukou committed Dec 15, 2025
commit 65f3fd08de8a3ba7e94d78c5f4de5e6f3a1e2125
101 changes: 60 additions & 41 deletions Lib/test/test_xxlimited.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,38 @@
import types

xxlimited = import_helper.import_module('xxlimited')
xxlimited_35 = import_helper.import_module('xxlimited_35')


class CommonTests:
module: types.ModuleType

def test_xxo_new(self):
xxo = self.module.Xxo()

def test_xxo_attributes(self):
xxo = self.module.Xxo()
# if import of xxlimited succeeded, the other ones should be importable.
import xxlimited_3_13
import xxlimited_35

MODULES = {
(3, 15): xxlimited,
(3, 13): xxlimited_3_13,
(3, 5): xxlimited_35,
}

def test_with_xxlimited_modules(since=None, until=None):
def _decorator(func):
def _wrapper(self, *args, **kwargs):
for version, module in MODULES.items():
if since and version < since:
continue
if until and version >= until:
continue
with self.subTest(version=version):
Comment thread
ZeroIntensity marked this conversation as resolved.
func(self, module, *args, **kwargs)
return _wrapper
return _decorator

class XXLimitedTests(unittest.TestCase):
@test_with_xxlimited_modules()
def test_xxo_new(self, module):
xxo = module.Xxo()

@test_with_xxlimited_modules()
def test_xxo_attributes(self, module):
xxo = module.Xxo()
with self.assertRaises(AttributeError):
xxo.foo
with self.assertRaises(AttributeError):
Expand All @@ -26,40 +47,46 @@ def test_xxo_attributes(self):
with self.assertRaises(AttributeError):
xxo.foo

def test_foo(self):
@test_with_xxlimited_modules()
def test_foo(self, module):
# the foo function adds 2 numbers
self.assertEqual(self.module.foo(1, 2), 3)
self.assertEqual(module.foo(1, 2), 3)

def test_str(self):
self.assertIsSubclass(self.module.Str, str)
self.assertIsNot(self.module.Str, str)
@test_with_xxlimited_modules()
def test_str(self, module):
self.assertIsSubclass(module.Str, str)
self.assertIsNot(module.Str, str)

custom_string = self.module.Str("abcd")
custom_string = module.Str("abcd")
self.assertEqual(custom_string, "abcd")
self.assertEqual(custom_string.upper(), "ABCD")

def test_new(self):
xxo = self.module.new()
@test_with_xxlimited_modules()
def test_new(self, module):
xxo = module.new()
self.assertEqual(xxo.demo("abc"), "abc")


class TestXXLimited(CommonTests, unittest.TestCase):
module = xxlimited

def test_xxo_demo(self):
xxo = self.module.Xxo()
other = self.module.Xxo()
@test_with_xxlimited_modules()
def test_xxo_demo(self, module):
xxo = module.Xxo()
self.assertEqual(xxo.demo("abc"), "abc")
self.assertEqual(xxo.demo(0), None)

@test_with_xxlimited_modules(since=(3, 13))
def test_xxo_demo_extra(self, module):
xxo = module.Xxo()
other = module.Xxo()
self.assertEqual(xxo.demo(xxo), xxo)
self.assertEqual(xxo.demo(other), other)
self.assertEqual(xxo.demo(0), None)

def test_error(self):
with self.assertRaises(self.module.Error):
raise self.module.Error
@test_with_xxlimited_modules(since=(3, 13))
def test_error(self, module):
with self.assertRaises(module.Error):
raise module.Error

def test_buffer(self):
xxo = self.module.Xxo()
@test_with_xxlimited_modules(since=(3, 13))
def test_buffer(self, module):
xxo = module.Xxo()
self.assertEqual(xxo.x_exports, 0)
b1 = memoryview(xxo)
self.assertEqual(xxo.x_exports, 1)
Expand All @@ -69,21 +96,13 @@ def test_buffer(self):
self.assertEqual(b1[0], 1)
self.assertEqual(b2[0], 1)


class TestXXLimited35(CommonTests, unittest.TestCase):
module = xxlimited_35

def test_xxo_demo(self):
xxo = self.module.Xxo()
other = self.module.Xxo()
self.assertEqual(xxo.demo("abc"), "abc")
self.assertEqual(xxo.demo(0), None)

@test_with_xxlimited_modules(until=(3, 5))
def test_roj(self):
# the roj function always fails
with self.assertRaises(SystemError):
self.module.roj(0)

@test_with_xxlimited_modules(until=(3, 5))
def test_null(self):
null1 = self.module.Null()
null2 = self.module.Null()
Expand Down