Skip to content

gh-130273: Fix traceback color output with unicode characters #142529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 11 commits into from
Apr 7, 2026
+144 −15
Merged

gh-130273: Fix traceback color output with unicode characters #142529

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
306a690
Fix traceback color output with unicode characters
grayjk Dec 10, 2025
8edad11
mv news blurb
grayjk Dec 10, 2025
7947033
use unicodedata.iter_graphemes
grayjk Jan 28, 2026
e8d23cd
Merge branch 'main' into issue-130273
grayjk Feb 18, 2026
467656e
mv wlen/str_width to traceback
grayjk Feb 19, 2026
05ad91e
Merge branch 'main' into pr-142529
ambv Apr 7, 2026
37a4fd9
Restore _pyrepl.utils.str_width and .wlen; respond to code review
ambv Apr 7, 2026
1318217
Remove ASCII fast track that was too eager
ambv Apr 7, 2026
7b3fa87
Add `_zip_display_width` fast track suggested by Victor
ambv Apr 7, 2026
4ddf024
Move str_width and wlen to the place in the file where they were before
ambv Apr 7, 2026
f094135
derp
ambv Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use unicodedata.iter_graphemes
  • Loading branch information
@grayjk
grayjk committed Jan 28, 2026
commit 794703397a2490f0cb587df8ce1118ea1fcc0404
17 changes: 4 additions & 13 deletions Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,22 +968,13 @@ def setup_positions(expr, force_valid=True):
return None


def _lookahead(iterator, default):
forked = itertools.tee(iterator, 1)[0]
return next(forked, default)


def _zip_display_width(line, carets):
line = itertools.tee(line, 1)[0]
import unicodedata
carets = iter(carets)
for char in line:
for char in unicodedata.iter_graphemes(line):
char = str(char)
char_width = _display_width(char)
next_char = _lookahead(line, "")
if next_char and char_width == _display_width(char + next_char):
next(line)
yield char + next_char, "".join(itertools.islice(carets, char_width))
else:
yield char, "".join(itertools.islice(carets, char_width))
yield char, "".join(itertools.islice(carets, char_width))
Comment thread
ambv marked this conversation as resolved.


Comment thread
ambv marked this conversation as resolved.
def _display_width(line, offset=None):
Expand Down
Loading