gh-142278: Add granular change detection for platforms in CI#142350
gh-142278: Add granular change detection for platforms in CI#142350hugovk merged 3 commits intopython:mainfrom
Conversation
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Let's also backport this, but wait a day or two before opening the backports, to check the logic is working as expected. |
|
Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to |
|
Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to |
|
Sounds good, I do the cherry-picking. |
brettcannon
left a comment
There was a problem hiding this comment.
Consider this notes for she next PR that edits this file.
| ANDROID_DIRS = frozenset({"Android"}) | ||
| IOS_DIRS = frozenset({"Apple", "iOS"}) | ||
| MACOS_DIRS = frozenset({"Mac"}) | ||
| WASI_DIRS = frozenset({Path("Tools", "wasm")}) |
There was a problem hiding this comment.
This is technically too broad as it includes Emscripten (since 3,14), but I don't think it's worth changing until the Platforms/ move happens.
| @@ -191,11 +263,16 @@ def write_github_output(outputs: Outputs) -> None: | |||
| return | |||
|
|
|||
| with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as f: | |||
There was a problem hiding this comment.
With the naming being so consistent, this could be simplified with a for loop with https://docs.python.org/3/library/dataclasses.html#dataclasses.fields .
…n CI (pythonGH-142350) (cherry picked from commit 9e3d7cd) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-142537 is a backport of this pull request to the 3.14 branch. |
…n CI (pythonGH-142350) (cherry picked from commit 9e3d7cd) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…n CI (pythonGH-142350) (cherry picked from commit 9e3d7cd) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-142578 is a backport of this pull request to the 3.13 branch. |
Uh oh!
There was an error while loading. Please reload this page.