Skip to content

[3.13] gh-140482: Avoid changing terminal settings in test_pty (gh-142202) #142238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Dec 5, 2025
+20 −20
Merged

[3.13] gh-140482: Avoid changing terminal settings in test_pty (gh-142202) #142238

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbce17
gh-140482: Avoid changing terminal settings in test_pty (gh-142202)
colesbury Dec 3, 2025
928bac6
No take_bytes() in 3.13
colesbury Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
No take_bytes() in 3.13
  • Loading branch information
@colesbury
colesbury committed Dec 3, 2025
commit 928bac69f10ec94535026aa24e431ead3eb274f8
2 changes: 1 addition & 1 deletion Lib/test/test_pty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def test_spawn_doesnt_hang(self):

(pid, status) = os.waitpid(pid, 0)
self.assertEqual(status, 0)
self.assertEqual(buf.take_bytes(), b"hi there\r\n")
self.assertEqual(bytes(buf), b"hi there\r\n")
finally:
os.close(fd)

Expand Down
Loading