Skip to content

GH-97850: Remove all uses and definitions of load_module() from importlib #142205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 9 commits into from
Dec 10, 2025
Merged

GH-97850: Remove all uses and definitions of load_module() from importlib #142205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d39b42d
GH-97850: Remove all uses and definitions of `load_module()` from imp…
brettcannon Dec 2, 2025
d70a7fb
Make the docs build happy
brettcannon Dec 2, 2025
e256f38
Remove references to `load_module()` from What's New
brettcannon Dec 2, 2025
845c868
Try to make the docs build happy
brettcannon Dec 3, 2025
ed166d8
Merge branch 'main' into remove-load_module
brettcannon Dec 8, 2025
b7def8f
Update Doc/library/importlib.rst
brettcannon Dec 9, 2025
2d571cc
Update Doc/library/importlib.rst
brettcannon Dec 9, 2025
0dd7fd8
Simplify import handling by removing namespace package logic
brettcannon Dec 9, 2025
b57d28e
Merge branch 'main' into remove-load_module
brettcannon Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove references to load_module() from What's New
  • Loading branch information
@brettcannon
brettcannon committed Dec 2, 2025
commit e256f38bb6439804946ffa5d3aa7165d21f194f7
4 changes: 2 additions & 2 deletions Doc/whatsnew/3.10.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1622,7 +1622,7 @@ Deprecated
compatibility. Specifically,
:meth:`!find_loader`/:meth:`!find_module`
(superseded by :meth:`~importlib.abc.MetaPathFinder.find_spec`),
:meth:`~importlib.abc.Loader.load_module`
``importlib.abc.Loader.load_module``
(superseded by :meth:`~importlib.abc.Loader.exec_module`),
:meth:`!module_repr` (which the import system
takes care of for you), the ``__package__`` attribute
Expand Down Expand Up @@ -1652,7 +1652,7 @@ Deprecated
preference for :meth:`~zipimport.zipimporter.exec_module`.
(Contributed by Brett Cannon in :issue:`26131`.)

* The use of :meth:`~importlib.abc.Loader.load_module` by the import
* The use of ``importlib.abc.Loader.load_module`` by the import
system now triggers an :exc:`ImportWarning` as
:meth:`~importlib.abc.Loader.exec_module` is preferred.
(Contributed by Brett Cannon in :issue:`26131`.)
Expand Down
8 changes: 4 additions & 4 deletions Doc/whatsnew/3.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2086,10 +2086,10 @@ Deprecations in the Python API
:meth:`!importlib.abc.PathEntryFinder.find_loader` and
:meth:`!find_module` are replaced by
:meth:`importlib.abc.PathEntryFinder.find_spec`; all of the :samp:`{xxx}Loader` ABC
``load_module`` methods (:meth:`!importlib.abc.Loader.load_module`,
:meth:`!importlib.abc.InspectLoader.load_module`,
:meth:`!importlib.abc.FileLoader.load_module`,
:meth:`!importlib.abc.SourceLoader.load_module`) should no longer be
``load_module`` methods (``importlib.abc.Loader.load_module``,
``importlib.abc.InspectLoader.load_module``,
``importlib.abc.FileLoader.load_module``,
``importlib.abc.SourceLoader.load_module``) should no longer be
implemented, instead loaders should implement an
``exec_module`` method
(:meth:`importlib.abc.Loader.exec_module`,
Expand Down
6 changes: 3 additions & 3 deletions Doc/whatsnew/3.6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,10 +2006,10 @@ deprecated.
importlib
~~~~~~~~~

The :meth:`importlib.machinery.SourceFileLoader.load_module` and
:meth:`importlib.machinery.SourcelessFileLoader.load_module` methods
The ``importlib.machinery.SourceFileLoader.load_module`` and
``importlib.machinery.SourcelessFileLoader.load_module`` methods
are now deprecated. They were the only remaining implementations of
:meth:`importlib.abc.Loader.load_module` in :mod:`importlib` that had not
``importlib.abc.Loader.load_module`` in :mod:`importlib` that had not
been deprecated in previous versions of Python in favour of
:meth:`importlib.abc.Loader.exec_module`.

Expand Down
Loading