Skip to content

GH-140638: Add a GC "duration" stat #141720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 5 commits into from
Nov 19, 2025
Merged

GH-140638: Add a GC "duration" stat #141720

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c30b79
Expose a GC "duration" stat
brandtbucher Nov 18, 2025
e11ca65
blurb add
brandtbucher Nov 18, 2025
f8f2ecb
fixup
brandtbucher Nov 18, 2025
cce1e16
Fix free-threading
brandtbucher Nov 18, 2025
fe8f02e
Fix duration in gc.get_stats()
brandtbucher Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@brandtbucher
brandtbucher committed Nov 18, 2025
commit f8f2ecb5a7be0e718c3dff1ce7b0a90d3acdaf2b
4 changes: 2 additions & 2 deletions Doc/library/gc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ The :mod:`gc` module provides the following functions:

.. versionadded:: 3.4

.. versionchanged:: 3.15
.. versionchanged:: next
Add ``duration``.


Expand Down Expand Up @@ -334,7 +334,7 @@ values but should not rebind them):

.. versionadded:: 3.3

.. versionchanged:: 3.14
.. versionchanged:: next
Add "duration".


Expand Down
3 changes: 0 additions & 3 deletions Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,6 @@ gc_collect_young(PyThreadState *tstate,
gc_list_init(&survivors);
gc_list_set_space(young, gcstate->visited_space);
gc_collect_region(tstate, young, &survivors, stats);
stats->visited += gcstate->young.count;
gc_list_merge(&survivors, visited);
validate_spaces(gcstate);
gcstate->young.count = 0;
Expand Down Expand Up @@ -1699,7 +1698,6 @@ gc_collect_increment(PyThreadState *tstate, struct gc_collection_stats *stats)
PyGC_Head survivors;
gc_list_init(&survivors);
gc_collect_region(tstate, &increment, &survivors, stats);
stats->visited += increment_size;
gc_list_merge(&survivors, visited);
assert(gc_list_is_empty(&increment));
gcstate->work_to_do -= increment_size;
Expand Down Expand Up @@ -1732,7 +1730,6 @@ gc_collect_full(PyThreadState *tstate,

gc_collect_region(tstate, visited, visited,
stats);
stats->visited += gcstate->young.count + gcstate->old[0].count + gcstate->old[1].count;
validate_spaces(gcstate);
gcstate->young.count = 0;
gcstate->old[0].count = 0;
Expand Down
Loading