gh-141341: Rename COMPILER macro to _Py_COMPILER on Windows#141342
Merged
Conversation
Member
Author
|
cc @picnixz |
picnixz
reviewed
Nov 10, 2025
| @@ -0,0 +1,2 @@ | |||
| On Windows, rename the ``COMPILER`` macro to ``_Py_COMPILER`` to avoid name | |||
Member
There was a problem hiding this comment.
Should we add something in "Porting to Python 3.15" as we were worried about possible consumers or do you think it's sufficient to only have it in the long changelog?
Member
Author
There was a problem hiding this comment.
COMPILER macro is not part of the official C API, so I don't think that it should be documented in the "What's New" document.
picnixz
approved these changes
Nov 10, 2025
Member
Author
|
Merged, thanks for your reviews! |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPILERmacro in the public C API #141341