Skip to content

gh-140947: fix contextvars handling for server tasks in asyncio #141158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 17 commits into from
Mar 21, 2026
Merged

gh-140947: fix contextvars handling for server tasks in asyncio #141158

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a7bf339
properly propagate contextvars for server protocols
kumaraditya303 Nov 3, 2025
40a8f7c
fix _add_writer
kumaraditya303 Dec 2, 2025
d786ca0
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Dec 12, 2025
6990bb9
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Jan 13, 2026
f845484
refactor 1
kumaraditya303 Jan 13, 2026
f556a84
all tests pass on mac
kumaraditya303 Jan 13, 2026
cbbf0c6
temp fix windows
kumaraditya303 Jan 13, 2026
ac7e954
Merge branch 'asyncio-contextvars-fix' of https://github.com/kumaradi…
kumaraditya303 Mar 21, 2026
b344e60
add tests
kumaraditya303 Mar 21, 2026
6a8e2bd
fix tests
kumaraditya303 Mar 21, 2026
ec0ed9b
add more windows tests
kumaraditya303 Mar 21, 2026
09df55e
fix ssl part
kumaraditya303 Mar 21, 2026
edcedbb
fix tests
kumaraditya303 Mar 21, 2026
e1ebe67
fix windows tests
kumaraditya303 Mar 21, 2026
c42e01c
Merge branch 'asyncio-contextvars-fix' of https://github.com/kumaradi…
kumaraditya303 Mar 21, 2026
a2039d6
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 21, 2026
69874d5
fix tests on machine without ssl
kumaraditya303 Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Lib/test/test_asyncio/test_base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,7 +1696,8 @@ def mock_make_ssl_transport(sock, protocol, sslcontext, waiter,
server_side=False,
server_hostname='python.org',
ssl_handshake_timeout=handshake_timeout,
ssl_shutdown_timeout=shutdown_timeout)
ssl_shutdown_timeout=shutdown_timeout,
context=ANY)
# Next try an explicit server_hostname.
self.loop._make_ssl_transport.reset_mock()
coro = self.loop.create_connection(
Expand All @@ -1711,7 +1712,8 @@ def mock_make_ssl_transport(sock, protocol, sslcontext, waiter,
server_side=False,
server_hostname='perl.com',
ssl_handshake_timeout=handshake_timeout,
ssl_shutdown_timeout=shutdown_timeout)
ssl_shutdown_timeout=shutdown_timeout,
context=ANY)
# Finally try an explicit empty server_hostname.
self.loop._make_ssl_transport.reset_mock()
coro = self.loop.create_connection(
Expand All @@ -1726,7 +1728,8 @@ def mock_make_ssl_transport(sock, protocol, sslcontext, waiter,
server_side=False,
server_hostname='',
ssl_handshake_timeout=handshake_timeout,
ssl_shutdown_timeout=shutdown_timeout)
ssl_shutdown_timeout=shutdown_timeout,
context=ANY)

def test_create_connection_no_ssl_server_hostname_errors(self):
# When not using ssl, server_hostname must be None.
Expand Down
Loading