bpo-28805: document METH_FASTCALL#14079
Merged
Merged
Conversation
mangrisano
suggested changes
Jun 15, 2019
Contributor
There was a problem hiding this comment.
Double space after a full stop.
mangrisano
suggested changes
Jun 15, 2019
Contributor
mangrisano
left a comment
There was a problem hiding this comment.
Hi, thank you for the pull request.
I've left a suggestion about the change.
Thank you. :)
methane
reviewed
Jun 16, 2019
| with signature :const:`METH_VARARGS | METH_KEYWORDS`. | ||
|
|
||
|
|
||
| .. c:type:: _PyCFunctionFast |
Member
There was a problem hiding this comment.
(just a comment) Maybe, we should remove the _ prefix in 3.9.
Contributor
Author
There was a problem hiding this comment.
Maybe, we should remove the
_prefix in 3.9.
Probably yes, together with doing the same for the vectorcall API.
methane
approved these changes
Jun 16, 2019
Contributor
Author
|
Thanks for the merge. Please remember to backport to 3.7 and 3.8. |
Contributor
Contributor
|
GH-14136 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 16, 2019
(cherry picked from commit 5600b5e) Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be>
|
GH-14137 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 16, 2019
miss-islington
added a commit
that referenced
this pull request
Jun 16, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only patch, so should be safe for backporting to 3.7 and 3.8
CC @methane @vstinner
https://bugs.python.org/issue28805