Skip to content

Update concurrent.futures.rst#14061

Merged
miss-islington merged 2 commits into
python:masterfrom
geryogam:patch-7
Jun 14, 2019
Merged

Update concurrent.futures.rst#14061
miss-islington merged 2 commits into
python:masterfrom
geryogam:patch-7

Conversation

@geryogam
Copy link
Copy Markdown
Contributor

@geryogam geryogam commented Jun 13, 2019 •
edited
Loading

This PR adds missing details in the concurrent.futures documentation:

  • the mention that Future.cancel also returns False if the call finished running;
  • the mention of the states for Future that did not complete: pending or running.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 13, 2019
asvetlov
asvetlov requested changes Jun 14, 2019
View reviewed changes
Comment thread Doc/library/concurrent.futures.rst
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 14, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

@maggyero: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

@maggyero: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 431478d into python:master Jun 14, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 14, 2019

GH-14082 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2019
@geryogam @miss-islington
Update concurrent.futures.rst (pythonGH-14061)
e9ba759 
This PR adds missing details in the [`concurrent.futures`](https://docs.python.org/3/library/concurrent.futures.html) documentation:

* the mention that `Future.cancel` also returns `False` if the call finished running;
* the mention of the states for `Future` that did not complete: pending or running.
(cherry picked from commit 431478d)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jun 14, 2019

Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 14, 2019

GH-14083 is a backport of this pull request to the 3.8 branch.

@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Jun 14, 2019

Thanks!

miss-islington added a commit that referenced this pull request Jun 14, 2019
@miss-islington @geryogam
Update concurrent.futures.rst (GH-14061)
0bd1469 
This PR adds missing details in the [`concurrent.futures`](https://docs.python.org/3/library/concurrent.futures.html) documentation:

* the mention that `Future.cancel` also returns `False` if the call finished running;
* the mention of the states for `Future` that did not complete: pending or running.
(cherry picked from commit 431478d)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Jun 14, 2019
@miss-islington @geryogam
Update concurrent.futures.rst (GH-14061)
047fa1d 
This PR adds missing details in the [`concurrent.futures`](https://docs.python.org/3/library/concurrent.futures.html) documentation:

* the mention that `Future.cancel` also returns `False` if the call finished running;
* the mention of the states for `Future` that did not complete: pending or running.
(cherry picked from commit 431478d)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam geryogam deleted the patch-7 branch June 14, 2019 15:11
@geryogam
Copy link
Copy Markdown
Contributor Author

geryogam commented Jun 14, 2019

@asvetlov Thank you for the review!

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@geryogam @lisroach
Update concurrent.futures.rst (pythonGH-14061)
c9ebf68 
This PR adds missing details in the [`concurrent.futures`](https://docs.python.org/3/library/concurrent.futures.html) documentation:

* the mention that `Future.cancel` also returns `False` if the call finished running;
* the mention of the states for `Future` that did not complete: pending or running.
This was referenced Sep 12, 2019
Merged
Merged
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@geryogam @DinoV
Update concurrent.futures.rst (pythonGH-14061)
4530c35 
This PR adds missing details in the [`concurrent.futures`](https://docs.python.org/3/library/concurrent.futures.html) documentation:

* the mention that `Future.cancel` also returns `False` if the call finished running;
* the mention of the states for `Future` that did not complete: pending or running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geryogam @bedevere-bot @miss-islington @asvetlov @the-knights-who-say-ni