Skip to content

[3.14] gh-140482: Preserve and restore stty echo as a test environment (GH-140519) #140562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warsaw merged 1 commit into from
Oct 24, 2025
Merged

[3.14] gh-140482: Preserve and restore stty echo as a test environment (GH-140519) #140562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-140482: Preserve and restore stty echo as a test environment (GH… 
…-140519)

(cherry picked from commit b3c713a)

Co-authored-by: Barry Warsaw <barry@python.org>
gh-140482: Restore `stty echo` as a test environment
  • Loading branch information
@warsaw @miss-islington
warsaw authored and miss-islington committed Oct 24, 2025
commit 74a3d5b1fffb7fce943428c7546a8dd1d9a08adb
26 changes: 26 additions & 0 deletions Lib/test/libregrtest/save_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@

from .utils import print_warning

# Import termios to save and restore terminal echo. This is only available on
# Unix, and it's fine if the module can't be found.
try:
import termios # noqa: F401
except ModuleNotFoundError:
pass


class SkipTestEnvironment(Exception):
pass
Expand Down Expand Up @@ -65,6 +72,7 @@ def __init__(self, test_name, verbose, quiet, *, pgo):
'shutil_archive_formats', 'shutil_unpack_formats',
'asyncio.events._event_loop_policy',
'urllib.requests._url_tempfiles', 'urllib.requests._opener',
'stty_echo',
)

def get_module(self, name):
Expand Down Expand Up @@ -292,6 +300,24 @@ def restore_warnings_showwarning(self, fxn):
warnings = self.get_module('warnings')
warnings.showwarning = fxn

def get_stty_echo(self):
termios = self.try_get_module('termios')
if not os.isatty(fd := sys.__stdin__.fileno()):
return None
attrs = termios.tcgetattr(fd)
lflags = attrs[3]
return bool(lflags & termios.ECHO)
def restore_stty_echo(self, echo):
termios = self.get_module('termios')
attrs = termios.tcgetattr(fd := sys.__stdin__.fileno())
if echo:
# Turn echo on.
attrs[3] |= termios.ECHO
else:
# Turn echo off.
attrs[3] &= ~termios.ECHO
termios.tcsetattr(fd, termios.TCSADRAIN, attrs)

def resource_info(self):
for name in self.resources:
method_suffix = name.replace('.', '_')
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2025-10-23-16-39-49.gh-issue-140482.ZMtyeD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Preserve and restore the state of ``stty echo`` as part of the test environment.
Loading