Skip to content

gh-140482: Preserve and restore stty echo as a test environment #140519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warsaw merged 5 commits into from
Oct 24, 2025
Merged

gh-140482: Preserve and restore stty echo as a test environment #140519

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bee101
gh-140482: Restore `stty echo` as a test environment
warsaw Oct 23, 2025
e1c2eed
Add a blurb
warsaw Oct 23, 2025
3bd8c8c
Respond to review comments.
warsaw Oct 24, 2025
ac677cc
Update a comment
warsaw Oct 24, 2025
4544c24
Ignore "imported but unused" linter warning on the import of termios
warsaw Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update a comment
  • Loading branch information
@warsaw
warsaw committed Oct 24, 2025
commit ac677cc22cbbd2ba1e01a56dcddc759c86df4c70
2 changes: 1 addition & 1 deletion Lib/test/libregrtest/save_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@

from .utils import print_warning

# Import termios to save and restore the tty. This is only available on
# Import termios to save and restore terminal echo. This is only available on
# Unix, and it's fine if the module can't be found.
try:
import termios

Check failure on line 15 in Lib/test/libregrtest/save_env.py

View workflow job for this annotation

GitHub Actions / lint

Ruff (F401) 

Lib/test/libregrtest/save_env.py:15:12: F401 `termios` imported but unused; consider using `importlib.util.find_spec` to test for availability
except ModuleNotFoundError:
pass
Comment thread
warsaw marked this conversation as resolved.

Expand Down
Loading