Skip to content

Fix tests: getsockname() can return None on OS X on unbound sockets #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
May 2, 2017
Merged

Fix tests: getsockname() can return None on OS X on unbound sockets #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4683,8 +4683,8 @@ def bind(self, sock, path):
raise

def testUnbound(self):
# Issue #30205
self.assertEqual(self.sock.getsockname(), '')
# Issue #30205 (note getsockname() can return None on OS X)

@vstinner vstinner May 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are now using the "bpo-xxx" syntax instead of "issue #xxx" to prevent GitHub to creating a link to the GitHub bug tracker.

self.assertIn(self.sock.getsockname(), ('', None))

def testStrAddr(self):
# Test binding to and retrieving a normal string pathname.
Expand Down