Skip to content

gh-139686: Make reloading a lazy module no-op #139857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 10 commits into from
Dec 12, 2025
Merged

gh-139686: Make reloading a lazy module no-op #139857

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd952d8
fix reload with lazy
QEDady Oct 9, 2025
e79e806
Make "sys.modules.get('importlib.util')" with "import importlib.util"…
QEDady Oct 9, 2025
19b01c2
Merge branch 'main' into fix-issue-139686
QEDady Oct 9, 2025
4d8c884
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 9, 2025
e146f6a
resolve comments
QEDady Oct 9, 2025
a64ccd6
one more dot
QEDady Oct 9, 2025
9d27502
Update reload documentation
QEDady Nov 27, 2025
a34d440
Merge branch 'main' into fix-issue-139686
QEDady Nov 27, 2025
0ddbc84
Merge branch 'main' into fix-issue-139686
brettcannon Nov 28, 2025
c5c434a
Merge branch 'main' into fix-issue-139686
brettcannon Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update reload documentation
  • Loading branch information
@QEDady
QEDady committed Nov 27, 2025
commit 9d2750289dd26e1a3bfb1eb1dd7d62b0bdd5f07b
6 changes: 6 additions & 0 deletions Doc/library/importlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ Functions
:exc:`ModuleNotFoundError` is raised when the module being reloaded lacks
a :class:`~importlib.machinery.ModuleSpec`.

.. versionchanged:: 3.14
Comment thread
brettcannon marked this conversation as resolved.
If *module* is a lazy module that has not yet been materialized (i.e.,
loaded via :class:`importlib.util.LazyLoader` and not yet accessed),
calling :func:`reload` is a no-op and returns the module unchanged.
This prevents the reload from unintentionally triggering the lazy load.

.. warning::
This function is not thread-safe. Calling it from multiple threads can result
in unexpected behavior. It's recommended to use the :class:`threading.Lock`
Expand Down
Loading