Skip to content

bpo-26806: add 30 to the recursion limit in IDLE's shell #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 16 commits into from
Jul 6, 2019
Merged

bpo-26806: add 30 to the recursion limit in IDLE's shell #13944

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
062b111
bpo-26806: transparently add 25 to the recursion limit in IDLE
taleinat Jun 10, 2019
7d7b622
add a test + bugfix
taleinat Jun 10, 2019
f3b93f5
add docstring + comment referencing the bpo issue
taleinat Jun 10, 2019
af3ee2b
address review comments
taleinat Jun 11, 2019
9ddd699
minor fix to uninstall_recursionlimit_wrappers()
taleinat Jun 11, 2019
38bab8d
update NEWS
taleinat Jun 11, 2019
57c8b7b
Merge remote-tracking branch 'origin/master' into pr_13944
terryjreedy Jul 5, 2019
6f6ca69
Use f-string for error message and test bad calls.
terryjreedy Jul 5, 2019
ca15c75
Add test note.
terryjreedy Jul 5, 2019
d89350c
Revise blurb and add idlelib NEWS item.
terryjreedy Jul 5, 2019
7e7d21d
Add paragraph to doc.
terryjreedy Jul 5, 2019
6c20f8c
Update idle.rst
terryjreedy Jul 6, 2019
e7427ee
Update run.py
terryjreedy Jul 6, 2019
fd05a6a
fix typo
taleinat Jul 6, 2019
2c1d8d5
fix whitespace
taleinat Jul 6, 2019
7d6c545
another whitespace fix
taleinat Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fix to uninstall_recursionlimit_wrappers()
  • Loading branch information
@taleinat
taleinat committed Jun 11, 2019
commit 9ddd699600d23116e2577acdb2ce9dac6ea0fe8b
4 changes: 2 additions & 2 deletions Lib/idlelib/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ def getrecursionlimit():
def uninstall_recursionlimit_wrappers():
"""Uninstall the recursion limit wrappers from the sys module."""
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy Jul 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is (only) needed for tests. Add line "# Needed for tests." so function is never deleted as 'unused'. (I have made similar notes for other test-only code.)
<Done.>

Copy link
Copy Markdown
Contributor Author

@taleinat taleinat Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be deleted if it is used in test code? Even if it were deleted, the tests would immediately break!

Also, there's no telling who might find other uses for this in the future.

Copy link
Copy Markdown
Member

@terryjreedy terryjreedy Jul 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me start over. I initially wasted time looking for where this was used in run.py. I like to mark test code (code we/IDLE only use as such). So I moved the comment, reworded, into the docstring and added a note that users could also use this. (Yeah, one of use might want to do so sometime.) I think that this is an improvement.

if (
getattr(sys.setrecursionlimit, '__wrapped__') and
getattr(sys.getrecursionlimit, '__wrapped__')
getattr(sys.setrecursionlimit, '__wrapped__', None) and
getattr(sys.getrecursionlimit, '__wrapped__', None)
):
sys.setrecursionlimit = sys.setrecursionlimit.__wrapped__
sys.getrecursionlimit = sys.getrecursionlimit.__wrapped__
Expand Down