gh-139156: Use PyBytesWriter in _PySSL_BytesFromBIO#139284
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@corona10 this pr is ready |
| return NULL; | ||
| } | ||
| char *str = PyBytesWriter_GetData(writer); | ||
| memcpy(str, data, size); |
There was a problem hiding this comment.
Hmm, @vstinner,
Isn’t PyBytesWriter_WriteBytes not really intended for this use case? Looking at the current codebase, most cases seem to just use memcpy.
There was a problem hiding this comment.
I also think that this is not needed.
vstinner
left a comment
There was a problem hiding this comment.
PyBytes_FromStringAndSize(data, size) is just fine. I don't see the point of replacing it.
PyBytesWriter is cleaner to replace PyBytes_FromStringAndSize(NULL, size).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Ah got it, I missed this deprecation message. @mhsong21 I think that you should find out usecase that are using |
Use PyBytesWriter in _PySSL_BytesFromBIO