Skip to content

Revert "gh-118803: Remove ByteString from typing and collections.abc (#118804)" #138990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 4 commits into from
Sep 16, 2025
Merged

Revert "gh-118803: Remove ByteString from typing and collections.abc (#118804)" #138990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be5d2e6
Revert "gh-118803: Remove `ByteString` from `typing` and `collections…
AlexWaygood Sep 16, 2025
0063249
blurb and docs
AlexWaygood Sep 16, 2025
8966dbc
revert some reverts
AlexWaygood Sep 16, 2025
74be029
silence this docs nitpick on old whatsnew
AlexWaygood Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert some reverts
  • Loading branch information
@AlexWaygood
AlexWaygood committed Sep 16, 2025
commit 8966dbc75cfd583f95b86d066ff8a3f0c2529d75
3 changes: 2 additions & 1 deletion Lib/_collections_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,7 @@ def count(self, value):

Sequence.register(tuple)
Sequence.register(str)
Sequence.register(bytes)
Sequence.register(range)
Sequence.register(memoryview)

Expand Down Expand Up @@ -1159,4 +1160,4 @@ def __iadd__(self, values):


MutableSequence.register(list)
MutableSequence.register(bytearray) # Multiply inheriting, see ByteString
MutableSequence.register(bytearray)
1 change: 0 additions & 1 deletion Lib/test/libregrtest/refleak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ def dash_R_cleanup(fs, ps, pic, zdc, abcs, linecache_data):
zipimport._zip_directory_cache.update(zdc)

# Clear ABC registries, restoring previously saved ABC registries.
# ignore deprecation warning for collections.abc.ByteString
abs_classes = [getattr(collections.abc, a) for a in collections.abc.__all__]
abs_classes = filter(isabstract, abs_classes)
for abc in abs_classes:
Expand Down
Loading